-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make additional OTel Collector components available in Agent running in OTel mode #4623
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
As requested by @strawgate for 8.15.0. |
We may also want to add resourcedetection and filter |
maybe not in this PR but we will need to replace memorylimiterprocessor with memorylimiterextension. |
go 1.21 | ||
go 1.21.0 | ||
|
||
toolchain go1.21.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go version is specified as 1.21.9
maybe we should match and update "bump go version" to update go.mod as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@strawgate thoughts on this? Are you okay with us switching to the |
176df27
to
f80c03d
Compare
go.mod
Outdated
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter v0.98.0 | ||
github.com/open-telemetry/opentelemetry-collector-contrib/processor/attributesprocessor v0.98.0 | ||
github.com/open-telemetry/opentelemetry-collector-contrib/processor/filterprocessor v0.99.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there will be a conflict: #4638
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait to get #4638 merged first since that's a more important change IMO and then I'll rebase this PR on main
.
This pull request is now in conflicts. Could you fix it? 🙏
|
f80c03d
to
432d4c1
Compare
432d4c1
to
0d6d918
Compare
@ycombinator I don't think i have any concerns so if you dont have any concerns then let's proceed |
If we can get hostmetrics and elasticsearch exporter for 8.14, that's a win in my book. So 2 with a big hope that it's not one of those two |
Thanks @strawgate. Trying out just Will layer on the other components from this PR one by one so we can get as many in as possible without the dependency conflict. |
Filed #4665 to track this change. |
It was |
08f6900
to
50f1dc2
Compare
Quality Gate passedIssues Measures |
@cmacknz pointed out (in Slack) that the "The service did not respond to the start or control request in a timely fashion" error in CI isn't happening on other branches so we need to be sure one of the changes in this PR isn't causing this error. I'm going to keep this PR open for now but create three additional PRs, one for each of the OTel Collector components being added to Agent. That way we can hopefully narrow down which component is causing the error and also get the other components in. |
|
Looks like it might be the |
This pull request is now in conflicts. Could you fix it? 🙏
|
Closing this PR in favor of individual PRs for the three components being added in this PR:
|
What does this PR do?
This PR makes the following additional OpenTelemetry Collector components available when Elastic Agent is running in
otel
mode:hostmetrics
receiverfilter
processorelasticsearch
exporterWhy is it important?
To allow users of Elastic Agent running as as OpenTelemetry Collector to configure pipelines containing the aforementioned components.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works./changelog/fragments
using the changelog toolI have added an integration test or an E2E test