-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use otel version 0.97.0 #4638
Use otel version 0.97.0 #4638
Conversation
This pull request does not have a backport label. Could you fix it @michalpristas? 🙏
NOTE: |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
Pavel and Olga are working on addressing macos failures |
@@ -41,11 +41,11 @@ require ( | |||
github.com/mitchellh/hashstructure v1.1.0 | |||
github.com/mitchellh/mapstructure v1.5.1-0.20231216201459-8508981c8b6c | |||
github.com/oklog/ulid v1.3.1 | |||
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/fileexporter v0.98.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a couple of newlines around this block of OTel dependencies or add a separate require
block for them to indicate that they are all related?
This would then give us an opportunity to add a comment here explaining why we're pinning to 0.97.0
for now and what is the criteria for undoing that pinning. That way, when dependabot tries to automatically bump the version, whoever reviews those PRs would immediately know whether to approve them or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we could separate
Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Quality Gate passedIssues Measures |
Backporting to |
* Use version 0.97.0 --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit a3900f0) # Conflicts: # NOTICE.txt # go.mod # go.sum # internal/pkg/otel/README.md # internal/pkg/otel/run.go
* Use otel version 0.97.0 (#4638) * Use version 0.97.0 --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit a3900f0) # Conflicts: # NOTICE.txt # go.mod # go.sum # internal/pkg/otel/README.md # internal/pkg/otel/run.go * Fix conflicts --------- Co-authored-by: Michal Pristas <michal.pristas@gmail.com> Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
Otel versions >0.97.0 have a bug where they expose metrics on :8888 even for validate subcommands causing our tests to fail.
related to this issue here: open-telemetry/opentelemetry-collector#10031
cause by pull open-telemetry/opentelemetry-collector#9257
Closes: #4617