Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add name to series specs #142

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Apr 1, 2019

Summary

fix #136

A name prop is now available for each series. This name will be used, if available, on every
legend or tooltip instead of the specId (used as fallback).

<BarSeries
    name={'Count'}
/>
<LineSeries
    name={'Count'}
/>
<AreaSeries
    name={'Count'}
/>

Screenshot 2019-04-01 at 23 22 42

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

A `name` prop is now available for each series. This name will be used, if available, on every
legend or tooltip instead of the specId (used as fallback).

fix elastic#136
@markov00 markov00 requested a review from emmacunningham April 1, 2019 21:25
@codecov-io
Copy link

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files          31       31           
  Lines        1481     1481           
  Branches      163      166    +3     
=======================================
  Hits         1375     1375           
  Misses         92       92           
  Partials       14       14
Impacted Files Coverage Δ
src/lib/series/specs.ts 100% <ø> (ø) ⬆️
src/lib/series/tooltip.ts 63.15% <100%> (ø) ⬆️
src/lib/series/legend.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b173d...0cf8835. Read the comment docs.

@markov00 markov00 mentioned this pull request Apr 1, 2019
93 tasks
Copy link
Contributor

@emmacunningham emmacunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally on Firefox & code LGTM

@markov00 markov00 merged commit a6e6f49 into elastic:master Apr 1, 2019
markov00 pushed a commit that referenced this pull request Apr 1, 2019
# [3.5.0](v3.4.5...v3.5.0) (2019-04-01)

### Bug Fixes

* **areachart:** fix misaligned rendering props  ([#141](#141)) ([9694b5b](9694b5b)), closes [#140](#140)

### Features

* **specs:** add name to series specs ([#142](#142)) ([a6e6f49](a6e6f49)), closes [#136](#136)
@markov00
Copy link
Member Author

markov00 commented Apr 1, 2019

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 1, 2019
@markov00 markov00 deleted the add-name-to-specs branch April 16, 2019 12:05
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to specify an id and a title (label) for series separately
3 participants