style(legend): align k7 design #54
Conversation
src/components/legend.tsx
Outdated
| 'elasticChartsLegend', | ||
| `elasticChartsLegend--${legendPosition}`, | ||
| legendCollapsed.get() && 'elasticChartsLegend--collapsed', | ||
| debug && 'elasticChartsLegend--debug', |
There was a problem hiding this comment.
Could use object for conditional classes?
{
'elasticChartsLegend--collapsed': legendCollapsed.get(),
'elasticChartsLegend--debug': debug,
}
src/components/tooltips.tsx
Outdated
| className={classNames('euiChartTooltip', showTooltip ? null : 'euiChartTooltip--hidden')} | ||
| className={classNames( | ||
| 'elasticChartsTooltip', | ||
| showTooltip ? null : 'elasticChartsTooltip--hidden', |
There was a problem hiding this comment.
similar to the suggestion in this comment, could use object for the conditional class?
|
Not sure if it is intentional, but it looks like the top position of the legend toggle changes slightly on hover? This is most noticeable when the toggle has focus w/ the gray background as there appears to be whitespace between the toggle and the edge of the container:
|
@emmacunningham this is the default behaviour of |
|
I dont think it's detrimental to the user, so I'd opt for leaving it as is.
…On Wed, Feb 13, 2019, 4:34 PM Marco Vettorello ***@***.*** wrote:
Not sure if it is intentional, but it looks like the top position of the
legend toggle changes slightly on hover? This is most noticeable when the
toggle has focus w/ the gray background as there appears to be whitespace
between the toggle and the edge of the container:
[image: legend_tooltip_hover_focus]
<https://user-images.githubusercontent.com/452850/52741567-7cf60100-2f8a-11e9-980d-8d26d86ff1f5.gif>
@emmacunningham <https://github.com/emmacunningham> this is the default
behaviour of EuIButtonIcon, @cchaos <https://github.com/cchaos> what do
you think? do I need to remove the animation? on dashboard we don't have
this because we are not using EUIButton directly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAhiyY_djruSYm0ML-ZCz7-TslmlLRGSks5vNITkgaJpZM4a5d5q>
.
|
|
👍 sounds good! agree it's not detrimental to the user. was just curious as i'm new to these things :) |
new the legend respect the chart theme margins. The toggle is now moved to the bottom left of the chart as in kibana new design. fix elastic#34
markov00
force-pushed
the
fix/legend-style
branch
from
0e377cf to
ff4b6aa
Compare
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR align the legend design to the K7 design with the toggle button is always on the bottom left of the chart.
fix #34