Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ignored fields error as xUnit error #1945

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Jul 3, 2024

This PR changes the error of the ignored fields to be shown as part of the xUnit files (XML).

Example for zeronetworks package from integrations repository:

FAILURE DETAILS:
zeronetworks/audit default:
found ignored fields in data stream logs-zeronetworks.audit-28964: [zeronetworks.audit.details.expiresAt zeronetworks.audit.details.protectionDate]. Affected documents: [
  {
    "_id": "WwOkI3UilYSxulaUzR+4QrFgAwQ=",
    "@timestamp": "2024-04-01T19:59:27.459Z",
    "ignored_field_values": {
      "zeronetworks.audit.details.protectionDate": [
        "01 May 24 20:00 UTC"
      ]
    }
  },
  {
    "_id": "miIZ4UaYlRX7GM5MhpGuC19AWF4=",
    "@timestamp": "2024-04-01T19:27:09.353Z",
    "ignored_field_values": {
      "zeronetworks.audit.details.expiresAt": [
        "01 Apr 24 19:48 UTC"
      ]
    }
  },
  {
    "_id": "HXfE07PTzjFSxG4kDTnrdup/7HU=",
    "@timestamp": "2024-04-01T18:43:10.675Z",
    "ignored_field_values": {
      "zeronetworks.audit.details.expiresAt": [
        "09 Apr 24 18:43 UTC"
      ]
    }
  },
  {
    "_id": "6Ltd0Ov89gBZD04zGDuWy7KV41g=",
    "@timestamp": "2024-04-01T16:06:50.678Z",
    "ignored_field_values": {
      "zeronetworks.audit.details.expiresAt": [
        "01 Apr 24 16:06 UTC"
      ]
    }
  },
  {
    "_id": "k/CKnSsz4WQ/1bH0+iOtLzHDRkE=",
    "@timestamp": "2024-04-01T15:23:44.397Z",
    "ignored_field_values": {
      "zeronetworks.audit.details.expiresAt": [
        "01 Apr 24 15:23 UTC"
      ]
    }
  }
]


╭──────────────┬─────────────┬───────────┬───────────┬───────────────────────────────────────────────────────────────────────────────────────────┬───────────────╮
│ PACKAGE      │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT                                                                                    │  TIME ELAPSED │
├──────────────┼─────────────┼───────────┼───────────┼───────────────────────────────────────────────────────────────────────────────────────────┼───────────────┤
│ zeronetworks │ audit       │ system    │ default   │ FAIL: test case failed: found ignored fields in data stream logs-zeronetworks.audit-28964 │ 40.114481494s │
╰──────────────┴─────────────┴───────────┴───────────┴───────────────────────────────────────────────────────────────────────────────────────────┴───────────────╯

@mrodm mrodm self-assigned this Jul 3, 2024
@mrodm
Copy link
Contributor Author

mrodm commented Jul 3, 2024

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repository to test this version. Check elastic/integrations#10358

@mrodm mrodm requested a review from a team July 3, 2024 17:29
@mrodm mrodm marked this pull request as ready for review July 3, 2024 17:29
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 4, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @mrodm

@mrodm mrodm enabled auto-merge (squash) July 4, 2024 08:20
@mrodm mrodm merged commit 41addb9 into elastic:main Jul 4, 2024
3 checks passed
@mrodm mrodm deleted the show_ignored_fields_error_in_xunit branch July 4, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants