Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show ignored fields error as xUnit error #1945

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Show ignored fields error as xUnit error #1945

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a51495
Show ignored fields error as xUnit error
mrodm Jul 3, 2024
19f80b2
Update reason message
mrodm Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/testrunner/runners/system/tester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1908,7 +1908,10 @@ func validateIgnoredFields(stackVersionString string, scenario *scenarioTest, co
return fmt.Errorf("failed to marshal degraded docs to JSON: %w", err)
}

return fmt.Errorf("found ignored fields in data stream %s: %v. Affected documents: %s", scenario.dataStream, ignoredFields, degradedDocsJSON)
return testrunner.ErrTestCaseFailed{
Reason: "found ignored fields in data stream",
Details: fmt.Sprintf("found ignored fields in data stream %s: %v. Affected documents: %s", scenario.dataStream, ignoredFields, degradedDocsJSON),
}
}

return nil
Expand Down