Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to integrations folder #285

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Remove reference to integrations folder #285

merged 1 commit into from
Mar 10, 2021

Conversation

ycombinator
Copy link
Contributor

This PR removes a reference to the integrations folder (resulting from checking out the elastic/integrations repository locally) from the README. This is because elastic-package should be usable regardless of whether packages are coming from the elastic/integrations repository or not.

@ycombinator ycombinator added the documentation Improvements or additions to documentation label Mar 9, 2021
@ycombinator ycombinator requested review from mtojek and jalvz March 9, 2021 20:18
@ycombinator ycombinator mentioned this pull request Mar 9, 2021
Merged
@ycombinator ycombinator requested a review from ruflin March 9, 2021 20:25
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #285 opened

  • Start Time: 2021-03-09T20:18:50.522+0000

  • Duration: 19 min 43 sec

  • Commit: 8dc0488

Test stats 🧪

Test Results
Failed 0
Passed 311
Skipped 1
Total 312

Trends 🧪

Image of Build Times

Image of Tests

@ycombinator ycombinator merged commit 56de8e1 into elastic:master Mar 10, 2021
@ycombinator ycombinator deleted the fix-readme branch March 10, 2021 14:05
jalvz
jalvz reviewed Mar 17, 2021
View reviewed changes
Copy link

@jalvz jalvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalvz jalvz jalvz left review comments

@mtojek mtojek mtojek approved these changes

@ruflin ruflin Awaiting requested review from ruflin

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ycombinator @elasticmachine @jalvz @mtojek