-
Notifications
You must be signed in to change notification settings - Fork 102
[apm] update apm production package with correct var types #1012
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill up the issue description justifying the PR.
Please link the appropriate Github issue.
I understand that this is an acknowledged risk to push directly to production branch, right? |
Today I tried elastic-package following https://github.com/elastic/elastic-package#getting-started and that didn't work. After running |
Hey @jalvz, ++ for getting this PR in so your colleagues are unblocked. And thank you for trying out |
To make a package available for testing, it is not required to be in the production branch, see table here: https://github.com/elastic/package-storage#package-storage As soon as APM because a package that is installed by default pushing to production directly is very risky as it might affect all of Kibana. We should only do this as an exception. |
|
Update APM production package with correct var types
Closes #1011