Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

[apm] update apm production package with correct var types #1012

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

jalvz
Copy link

@jalvz jalvz commented Mar 9, 2021

Update APM production package with correct var types

Closes #1011

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1012 opened

  • Start Time: 2021-03-09T12:39:06.413+0000

  • Duration: 17 min 42 sec

  • Commit: 532fe9b

Test stats 🧪

Test Results
Failed 0
Passed 60
Skipped 0
Total 60

Trends 🧪

Image of Build Times

Image of Tests

@mtojek mtojek self-requested a review March 9, 2021 13:36
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill up the issue description justifying the PR.

Please link the appropriate Github issue.

@jalvz jalvz requested a review from mtojek March 9, 2021 14:53
@mtojek
Copy link
Contributor

mtojek commented Mar 9, 2021

I understand that this is an acknowledged risk to push directly to production branch, right?

@jalvz
Copy link
Author

jalvz commented Mar 9, 2021

Today I tried elastic-package following https://github.com/elastic/elastic-package#getting-started and that didn't work.

After running make build there is no integrations folder (can't cd integrations). I didn't have time to dig deeper, so I guess so. I will get back to it next week, didn't want to prevent my colleagues from testing with a prod package in the meanwhile.

@jalvz jalvz merged commit be1305a into elastic:production Mar 9, 2021
@ycombinator
Copy link
Contributor

Hey @jalvz, ++ for getting this PR in so your colleagues are unblocked. And thank you for trying out elastic-package. I see that the README has a step to cd integrations which obviously isn't generally applicable. I will fix the README now so it's clearer.

@ruflin
Copy link
Contributor

ruflin commented Mar 9, 2021

To make a package available for testing, it is not required to be in the production branch, see table here: https://github.com/elastic/package-storage#package-storage

As soon as APM because a package that is installed by default pushing to production directly is very risky as it might affect all of Kibana. We should only do this as an exception.

@ycombinator
Copy link
Contributor

I will fix the README now so it's clearer.

elastic/elastic-package#285

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants