Accept Terms value to be any iterable #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roxanebellot
force-pushed
the
fix/1641-terms-iterable
branch
from
dae98b3 to
f434f46
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
Co-authored-by: Roxane <r.bellot@octopusmind.info> (cherry picked from commit 8cc2ed2)
miguelgrinberg
pushed a commit
that referenced
this pull request
Aug 22, 2024
|
Thank you for your persistence Roxane! |
|
fyi -- the way this is implemented a term of "test" will turn into a query for |
|
@abrin Good news! This was fixed in https://github.com/elastic/elasticsearch-dsl-py/releases/tag/v8.15.3, released one hour ago. |
miguelgrinberg
pushed a commit
to miguelgrinberg/elasticsearch-dsl-py
that referenced
this pull request
Dec 9, 2024
Co-authored-by: Roxane <r.bellot@octopusmind.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1641
CLA is signed, PR is rebased !