Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accepts boost param on Terms #1904

Closed
wants to merge 1 commit into from
Closed

Accepts boost param on Terms #1904

wants to merge 1 commit into from

Conversation

jairhenrique
Copy link

#1887 introduced a bug when we tried to pass a boost in the search for terms.

This PR ignores the value list transformation when param name is boost.

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Sep 9, 2024 •
edited
Loading

💚 CLA has been signed

@miguelgrinberg miguelgrinberg mentioned this pull request Sep 11, 2024
Closed
@miguelgrinberg
Copy link
Collaborator

miguelgrinberg commented Sep 11, 2024 •
edited
Loading

Thanks! Unfortunately this fix only looks for boost, but for robustness we want to make sure anything that is not iterable is passed as is. I'm working on a more complete fix that will be released soon. See #1907

@jairhenrique jairhenrique deleted the terms-boost branch September 11, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jairhenrique @miguelgrinberg