Generate types for the Elasticsearch responses #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
autogenerate-responses
branch
2 times, most recently
from
50cb86b to
118ff63
Compare
miguelgrinberg
commented
Oct 18, 2024
| @@ -41,11 +44,47 @@ | |||
|
|
|||
|
|
|||
| class Response(AttrDict[Any], Generic[_R]): | |||
| """An Elasticsearch response. | |||
|
|
|||
| :arg took: (required) | |||
There was a problem hiding this comment.
Sadly none of the response attributes appear to have documentation.
miguelgrinberg
force-pushed
the
autogenerate-responses
branch
from
118ff63 to
29f4864
Compare
miguelgrinberg
commented
Oct 18, 2024
miguelgrinberg
commented
Oct 18, 2024
miguelgrinberg
commented
Oct 18, 2024
pquentin
approved these changes
Oct 18, 2024
Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* generate types for the Elasticsearch response * typing of the update by query response * minor typing updates * Update utils/templates/response.__init__.py.tpl Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> --------- Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> (cherry picked from commit 579f572)
miguelgrinberg
added a commit
that referenced
this pull request
Oct 18, 2024
* generate types for the Elasticsearch response * typing of the update by query response * minor typing updates * Update utils/templates/response.__init__.py.tpl Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> --------- Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> (cherry picked from commit 579f572) Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg
added a commit
to miguelgrinberg/elasticsearch-dsl-py
that referenced
this pull request
Dec 9, 2024
* generate types for the Elasticsearch response * typing of the update by query response * minor typing updates * Update utils/templates/response.__init__.py.tpl Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> --------- Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds types to the search and update by query Elasticsearch response classes. Still to do are the aggregations and the
Hitclass, which will be added separately.