-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bucketsPath syntax for lower and upper standard deviation bounds in the extended_stats aggregation more obvious #19040
Comments
+1 |
… extended_stats aggregation more obvious Fix for elastic#19040
@colings86 Can I continue to work on this? Thanks in advance. 😄 |
@liketic if you are able to raise a PR for this then that would be great, thanks |
@colings86 Thanks for your reply! 👍 If I'm not wrong, we expect to access elasticsearch/core/src/main/java/org/elasticsearch/search/aggregations/support/AggregationPath.java Line 86 in e7d352b
We didn't support access value more than one levels which means Is that the correct direction? Any comments are appreciated. 😄 |
@liketic this is actually a bit tricky because the pattern for a valid aggregation name is: https://github.com/elastic/elasticsearch/blob/master/core/src/main/java/org/elasticsearch/search/aggregations/AggregatorFactories.java#L53 So the reason why the line you linked to calls Because of this its going to be difficult to change the path to I would if we should make a change to stop dots in the aggregation names so we can make this change or if we should instead keep the current limitation of metrics not containing dots and not worry about this issue? @jpountz @clintongormley what do you think? |
@colings86 I can't think of a reason for supporting dot in aggregation names, esp as we don't support dots in field names (dots are treated as object paths). I'd be in favour of removing support (deprecating in 6.x and removing in 7.0) |
cc @elastic/es-search-aggs |
Dots in aggregation names can lead to tricky parsing situations, like being unable to sort by agg names with dots. This adds a deprecation logger and a note in the docs, letting us remove them in 8.0. Related to elastic#17600 and elastic#19040
We kind of made it worse recently by adding population and sampling bounds in #49782. Maybe it is time to clean this up |
Added to the refactor issue for bucket / pipeline aggs |
Closing as not planned, focus is on ES|QL development |
This issue was raised on the forum here: https://discuss.elastic.co/t/accessing-lower-bound-of-extended-stats-bucket/53763
The output of the extended_stats aggregation looks like this:
but the buckets paths to get the upper and lower standard deviation bounds are
my_stats.std_lower
andmy_stats.std_upper
which is not very intuitive given the output above. I think we should change it so the buckets_path (and terms sort path) ismy_stats.std_deviation_bounds.lower
andmy_stats.std_deviation_bounds.upper
The text was updated successfully, but these errors were encountered: