forked from elastic/elasticsearch
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Dots in aggregation names can lead to tricky parsing situations, like being unable to sort by agg names with dots. This adds a deprecation logger and a note in the docs, letting us remove them in 8.0. Related to elastic#17600 and elastic#19040
- Loading branch information
1 parent
90d62e6
commit 646e1e9
Showing
4 changed files
with
94 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
rest-api-spec/src/main/resources/rest-api-spec/test/search.aggregation/00_generic.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
setup: | ||
- do: | ||
indices.create: | ||
index: test_1 | ||
body: | ||
settings: | ||
number_of_replicas: 0 | ||
mappings: | ||
doc: | ||
properties: | ||
int_field: | ||
type : integer | ||
double_field: | ||
type : double | ||
string_field: | ||
type: keyword | ||
|
||
- do: | ||
bulk: | ||
refresh: true | ||
body: | ||
- index: | ||
_index: test_1 | ||
_type: doc | ||
_id: 1 | ||
- int_field: 1 | ||
double_field: 1.0 | ||
string_field: foo | ||
- index: | ||
_index: test_1 | ||
_type: doc | ||
_id: 2 | ||
- int_field: 51 | ||
double_field: 51.0 | ||
string_field: foo | ||
- index: | ||
_index: test_1 | ||
_type: doc | ||
_id: 3 | ||
- int_field: 101 | ||
double_field: 101.0 | ||
string_field: foo | ||
- index: | ||
_index: test_1 | ||
_type: doc | ||
_id: 4 | ||
- int_field: 151 | ||
double_field: 151.0 | ||
string_field: foo | ||
|
||
--- | ||
"Dots in agg names": | ||
|
||
- skip: | ||
version: " - 6.3.99" | ||
reason: this feature was deprecated in 6.4.0 | ||
features: "warnings" | ||
- do: | ||
warnings: | ||
- "Dots in aggregation names are deprecated and will be removed in 8.0" | ||
search: | ||
body: | ||
aggs: | ||
dots.in.agg.name: | ||
avg: | ||
field: int_field | ||
|
||
- match: { hits.total: 4 } | ||
- length: { hits.hits: 4 } | ||
- match: | ||
aggregations: | ||
dots.in.agg.name: | ||
value: 76.0 | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters