Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] ClassificationIT.testTooLowConfiguredMemoryStillStarts & RunDataFrameAnalyticsIT.testModelMemoryLimitLowerThanEstimatedMemoryUsage #61561

Closed
ywangd opened this issue Aug 25, 2020 · 3 comments · Fixed by #61576 or #61846
Assignees
Labels
:ml Machine learning >test-failure Triaged test failures from CI

Comments

@ywangd
Copy link
Member

ywangd commented Aug 25, 2020

Build scan:
https://gradle-enterprise.elastic.co/s/lqjgfg43cew4q
Note it has two failed tests

Repro line:

./gradlew ':x-pack:plugin:ml:qa:native-multi-node-tests:integTest' --tests "org.elasticsearch.xpack.ml.integration.ClassificationIT.testTooLowConfiguredMemoryStillStarts" -Dtests.seed=B6982EE4D20C808E -Dtests.security.manager=true -Dtests.locale=es-CL -Dtests.timezone=Australia/West -Druntime.java=11

./gradlew ':x-pack:plugin:ml:qa:native-multi-node-tests:integTest' --tests "org.elasticsearch.xpack.ml.integration.RunDataFrameAnalyticsIT.testModelMemoryLimitLowerThanEstimatedMemoryUsage" -Dtests.seed=B6982EE4D20C808E -Dtests.security.manager=true -Dtests.locale=sr-RS -Dtests.timezone=America/Sitka -Druntime.java=11

Reproduces locally?:
No

Applicable branches:
master

Failure history:

The method testModelMemoryLimitLowerThanEstimatedMemoryUsage failed for the very first faliure in last 30 days according to build-stats. I was gonna let it pass, but then I noticed that testTooLowConfiguredMemoryStillStarts is a new method added in today's changes. Both methods are touched in the change set. So there might be something going on.

Failure excerpt:

java.lang.AssertionError: |  
-- | --
  | Expected: <0L> |  
  | but: was <1L> |  


at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18) |  
-- | --
  |   | •••
  |   | at org.elasticsearch.xpack.ml.integration.MlNativeDataFrameAnalyticsIntegTestCase.cleanUpAnalytics(MlNativeDataFrameAnalyticsIntegTestCase.java:96) |  
  |   | at org.elasticsearch.xpack.ml.integration.MlNativeDataFrameAnalyticsIntegTestCase.cleanUpResources(MlNativeDataFrameAnalyticsIntegTestCase.java:87) |  
  |   | at org.elasticsearch.xpack.ml.integration.MlNativeIntegTestCase.cleanUp(MlNativeIntegTestCase.java:181) |  
  |   | at org.elasticsearch.xpack.ml.integration.RunDataFrameAnalyticsIT.cleanup(RunDataFrameAnalyticsIT.java:62)


@ywangd ywangd added >test-failure Triaged test failures from CI :ml Machine learning labels Aug 25, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@nik9000
Copy link
Member

nik9000 commented Sep 1, 2020

@nik9000 nik9000 reopened this Sep 1, 2020
@benwtrent
Copy link
Member

Yeah, more discussion here #61704

I think we have found the cause. Hopefully it will get fixed soon. It can be muted for the time being.

nik9000 added a commit that referenced this issue Sep 1, 2020
benwtrent added a commit that referenced this issue Sep 2, 2020
benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Sep 2, 2020
benwtrent added a commit that referenced this issue Sep 2, 2020
)

* [ML] unmute testTooLowConfiguredMemoryStillStarts (#61846)

Native PR addresses this test failure: elastic/ml-cpp#1465


closes #61704

closes #61561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >test-failure Triaged test failures from CI
Projects
None yet
4 participants