[ML] do not fail to start analytics process if memory estimate is lower than predicted memory usage #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
changed the title
|
This change seemed simple to me. Hopefully I didn't miss any "gotchas" Our instrumentation will automatically detect when memory usage is higher than the configured limit and throw a fatal. See: |
droberts195
reviewed
Sep 1, 2020
| BOOST_REQUIRE_EQUAL(1, static_cast<int>(errors.size())); | ||
| BOOST_TEST_REQUIRE(re.matches(errors[0])); | ||
| // no error should be registered | ||
| BOOST_REQUIRE_EQUAL(0, static_cast<int>(errors.size())); |
There was a problem hiding this comment.
Casting to int is a leftover from CppUnit, which required the LHS and RHS types to be exactly the same. Boost.Test doesn't, so the cast is just noise now. But no need to make another commit just to change this, as it had the cast before too.
benwtrent
deleted the
feature/ml-dont-fail-to-start-due-to-memory-limits
branch
benwtrent
added a commit
that referenced
this pull request
Sep 1, 2020
…er than predicted memory usage (#1465) (#1467) From the management side, we allow users to update configured memory limits after the analytics configuration has started. To help users with their workflow, we should allow analytics processes to attempt to run even if the configured memory limit is lower than our memory estimate. related to: elastic/elasticsearch#61505
benwtrent
added a commit
to elastic/elasticsearch
that referenced
this pull request
Sep 2, 2020
Native PR addresses this test failure: elastic/ml-cpp#1465 closes #61704 closes #61561
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Sep 2, 2020
Native PR addresses this test failure: elastic/ml-cpp#1465 closes elastic#61704 closes elastic#61561
benwtrent
added a commit
to elastic/elasticsearch
that referenced
this pull request
Sep 2, 2020
) * [ML] unmute testTooLowConfiguredMemoryStillStarts (#61846) Native PR addresses this test failure: elastic/ml-cpp#1465 closes #61704 closes #61561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the management side, we allow users to update configured memory limits after the analytics configuration has started.
To help users with their workflow, we should allow analytics processes to attempt to run even if the configured memory limit is lower than our memory estimate.
related to: elastic/elasticsearch#61505