Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete might returns false isFound() while primary is relocated #8706

Closed
s1monw opened this issue Nov 29, 2014 · 2 comments
Closed

Delete might returns false isFound() while primary is relocated #8706

s1monw opened this issue Nov 29, 2014 · 2 comments
Labels
>bug :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >test-failure Triaged test failures from CI

Comments

@s1monw
Copy link
Contributor

s1monw commented Nov 29, 2014

here is a link to a relevant failure: http://build-us-00.elasticsearch.org/job/es_core_master_metal/5665/

the test is indexing into a single shard with 0 replicas and this only shard is moving from node 0 to node 1. During the time we index the documents we mark the primary as started but until the clusterstate is published on node 0 it depends on which node you hit for indexing if the doc goes into both shards or not. Now if you hit node 1 the doc only goes into the new started (relocated) primary. Yet if you are fast enough and hit node 0 for the delete we can't find the doc in the currently relocating (clusterstate is not yet updated) - the logic knows it needs to push the delete into the new primary on node 1 so it really get's deleted but we return the response from node 0 which has isFound = false

@s1monw s1monw added the >bug label Nov 29, 2014
s1monw added a commit that referenced this issue Nov 29, 2014
s1monw added a commit that referenced this issue Nov 29, 2014
@s1monw
Copy link
Contributor Author

s1monw commented Nov 29, 2014

FYI - I disabled the check for now since it might bring up other failures here and there if timing allows. We should reenable the check once we have a fix - I added a log line instead

@s1monw s1monw added the >test-failure Triaged test failures from CI label Nov 29, 2014
@bleskes
Copy link
Contributor

bleskes commented Dec 19, 2014

@s1monw s1monw added v1.6.0 and removed v1.5.0 labels Mar 17, 2015
@clintongormley clintongormley added the :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. label Jun 7, 2015
@spinscale spinscale added v2.3.0 and removed v2.2.0 labels Dec 23, 2015
ywelsch pushed a commit to ywelsch/elasticsearch that referenced this issue Feb 2, 2016
@ywelsch ywelsch closed this as completed in cf28d62 Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests

4 participants