Implement proper handoff between primary copies during relocation #15532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areek
added
>enhancement
review
resiliency
:Distributed Indexing/Recovery
areek
force-pushed
the
wait_for_pending_ops
branch
2 times, most recently
from
11d4202 to
6ac9b7a
Compare
Now we mark the source copy as relocated after replaying the translog to target during relocation, blocking till all pending operations complete. Any further write operations are blocked on relocated shard copies, they are retried when relocation has completed
areek
force-pushed
the
wait_for_pending_ops
branch
from
6ac9b7a to
3252035
Compare
|
@bleskes I have simplified this PR based on our discussion. Updated the description with the implemented approach. |
|
Closed in favour of #15900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a clean handoff between shard copies during primary relocation.
After replaying the translog to target copy during relocation, the source copy is
marked as
relocated. Further writes are blocked onrelocatedshard copiesand are retried until relocation completes (waits for the cluster state to point to
the new copy).
The recovery process blocks until all pending writes complete on the source copy.
In case of failure/cancellation of recoveries after the source copy has been marked
as
relocated, the source state is marked back tostartedand resumes to acceptwrites.
relates #8706