Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does test-full-bwc work? #100413

Closed
wants to merge 7 commits into from
Closed

Does test-full-bwc work? #100413

wants to merge 7 commits into from

Conversation

DaveCTurner
Copy link
Contributor

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@DaveCTurner DaveCTurner added the test-full-bwc Trigger full BWC version matrix tests label Oct 6, 2023
@DaveCTurner DaveCTurner force-pushed the 2023/10/06/full-bwc-test-check branch from cb14db0 to 23fba63 Compare October 6, 2023 13:34
@DaveCTurner DaveCTurner mentioned this pull request Oct 6, 2023
Merged
@mark-vieira
Copy link
Contributor

I'm hitting the same weird failures in a PR of mine as well after #100401. I've seen weird behavior with AssumptionViolatedExceptions being thrown before and it makes no sense. That should not result in a test failure.

@DaveCTurner
Copy link
Contributor Author

Henning helped me pin it down, it's this I think: #100423

@mark-vieira
Copy link
Contributor

mark-vieira commented Oct 6, 2023 •
edited
Loading

Henning helped me pin it down, it's this I think: #100423

👍 Yeah, I'm seeing failures outside of PR builds as well so it does seem like a real issue: https://gradle-enterprise.elastic.co/s/rgdcfyecx33jy

So I think the answer is test-full-bwc does indeed work 😉

@DaveCTurner
Copy link
Contributor Author

Yeah sorry #100401 was a bit of a rush job to get it into a 8.10.x release. Move fast, break things, right?

@DaveCTurner DaveCTurner closed this Oct 6, 2023
@DaveCTurner DaveCTurner deleted the 2023/10/06/full-bwc-test-check branch October 6, 2023 18:33
@DaveCTurner DaveCTurner restored the 2023/10/06/full-bwc-test-check branch June 17, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test-full-bwc Trigger full BWC version matrix tests v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaveCTurner @mark-vieira @elasticsearchmachine