Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid resetting feature states before 7.13.0 #100423

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Avoid resetting feature states before 7.13.0 #100423

merged 2 commits into from
Oct 6, 2023

Conversation

DaveCTurner
Copy link
Contributor

This API was introduced in 7.13.0, we cannot call it on earlier nodes.

@DaveCTurner
Avoid resetting feature states before 7.13.0
48637ea 
This API was introduced in 7.13.0, we cannot call it on earlier nodes.
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Core/Infra/REST API REST infrastructure and utilities test-full-bwc Trigger full BWC version matrix tests v8.11.1 v8.12.0 v8.10.4 labels Oct 6, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Oct 6, 2023
@DaveCTurner DaveCTurner mentioned this pull request Oct 6, 2023
Closed
@DaveCTurner
Copy link
Contributor Author

The full-bwc failures are not relevant, and getting a completely clean run on full-bwc is hard right now. I think this is good to merge.

@DaveCTurner DaveCTurner mentioned this pull request Oct 6, 2023
Closed
nik9000
nik9000 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amen

@DaveCTurner DaveCTurner removed the test-full-bwc Trigger full BWC version matrix tests label Oct 6, 2023
@DaveCTurner DaveCTurner merged commit 87b1815 into elastic:main Oct 6, 2023
@DaveCTurner DaveCTurner deleted the 2023/10/06/resetFeatureStates-bwc branch October 6, 2023 18:27
@DaveCTurner DaveCTurner mentioned this pull request Oct 6, 2023
Merged
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Oct 6, 2023
@DaveCTurner
Avoid resetting feature states before 7.13.0 (elastic#100423)
e010793 
This API was introduced in 7.13.0, we cannot call it on earlier nodes.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Oct 6, 2023
@DaveCTurner
Avoid resetting feature states before 7.13.0 (elastic#100423)
b63d078 
This API was introduced in 7.13.0, we cannot call it on earlier nodes.
@DaveCTurner DaveCTurner mentioned this pull request Oct 6, 2023
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.11
✅ 8.10

elasticsearchmachine pushed a commit that referenced this pull request Oct 6, 2023
@DaveCTurner
Avoid resetting feature states before 7.13.0 (#100423) (#100454)
2c9392e 
This API was introduced in 7.13.0, we cannot call it on earlier nodes.
elasticsearchmachine pushed a commit that referenced this pull request Oct 6, 2023
@DaveCTurner
Avoid resetting feature states before 7.13.0 (#100423) (#100453)
8883708 
This API was introduced in 7.13.0, we cannot call it on earlier nodes.
@DaveCTurner DaveCTurner restored the 2023/10/06/resetFeatureStates-bwc branch June 17, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

@ldematte ldematte Awaiting requested review from ldematte

@williamrandolph williamrandolph Awaiting requested review from williamrandolph

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.10.4 v8.11.1 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaveCTurner @elasticsearchmachine @nik9000