Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the internal highlighter APIs, use the field type as opposed to the mapper. #31039

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

jtibshirani
Copy link
Contributor

A preparatory refactor for the work on field aliases.

@jtibshirani jtibshirani force-pushed the refactor/highlighter branch from 2423fde to b754cd6 Compare June 3, 2018 23:34
@jtibshirani jtibshirani added :Search Relevance/Highlighting How a query matched a document v7.0.0 >refactoring and removed WIP labels Jun 4, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jtibshirani jtibshirani merged commit 609de08 into elastic:master Jun 4, 2018
@jtibshirani jtibshirani deleted the refactor/highlighter branch June 4, 2018 18:12
jtibshirani added a commit that referenced this pull request Jun 4, 2018
dnhatn added a commit that referenced this pull request Jun 4, 2018
* master:
  Match phrase queries against non-indexed fields should throw an exception (#31060)
  In the internal highlighter APIs, use the field type as opposed to the mapper. (#31039)
  [DOCS] Removes duplicated authentication pages
  Enable customizing REST tests blacklist (#31074)
  Make sure KeywordFieldMapper#clone preserves split_queries_on_whitespace. (#31049)
  [DOCS] Moves machine learning overview to stack-docs
  [ML] Add secondary sort to ML events (#31063)
  [Rollup] Specialize validation exception for easier management (#30339)
  Adapt bwc versions after backporting #31045 to 6.3
  Remove usage of explicit type in docs (#29667)
  Share common readFrom/writeTo code in AcknowledgeResponse (#30983)
  Adapt bwc versions after backporting #31045 to 6.x
  Mute MatchPhrase*QueryBuilderTests
  [Docs] Fix typo in watcher conditions documentation (#30989)
  Remove wrong link in index phrases doc
  Move pipeline APIs to ingest namespace (#31027)
  [DOCS] Fixes accounting setting names (#30863)
  [DOCS] Rewords _field_names documentation (#31029)
  Index phrases (#30450)
  Remove leftover debugging from PTCMDT
  Fix PTCMDT#testMinVersionSerialization
  Make Persistent Tasks implementations version and feature aware (#31045)
martijnvg added a commit that referenced this pull request Jun 5, 2018
* es/6.x:
  Fix compil after backport
  Fix index prefixes to work with span_multi (#31066)
  Delete superfluous UpdateRequest test
  Disable MultiMatchQueryBuilderTests.
  Disable UpdateRequestTest#testUnknownFieldParsing.
  Update get.asciidoc (#31084)
  When the 'strict' mapping option is enabled, make sure to validate split_queries_on_whitespace.
  Transport client: Don't validate node in handshake (#30737) (#31080)
  In the internal highlighter APIs, use the field type as opposed to the mapper. (#31039)
  [DOCS] Removes redundant authorization pages
  Upgrade to Lucene-7.4.0-snapshot-0a7c3f462f (#31073)
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants