Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get.asciidoc #31084

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Update get.asciidoc #31084

merged 1 commit into from
Jun 4, 2018

Conversation

demisx
Copy link
Contributor

@demisx demisx commented Jun 4, 2018 •
edited
Loading

Fix typo in "Get" request documentation.

@jtibshirani
Copy link
Contributor

Hi @demisx, thank you for the fix! Just for proper protocol, I'm going to kick off a docs build before merging.

One small comment: would you mind updating the PR title to be more descriptive (something like 'Fix a typo in the 'get' request documentation')?

@jtibshirani jtibshirani added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.0.0 v6.4.0 labels Jun 4, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jtibshirani
Copy link
Contributor

@elasticmachine test this please

@jtibshirani
Copy link
Contributor

I also just realized that this PR is against the 6.2 branch -- would you be able to switch the base branch to master? Our workflow is to open PRs against master, and follow-up with backport commits (which I can handle).

@demisx demisx changed the base branch from 6.2 to master June 4, 2018 19:15
@demisx
Copy link
Contributor Author

demisx commented Jun 4, 2018

@jtibshirani No problem. I've just clicked on the "Edit" button in the docs and followed the current defaults. This is how I've ended up with this PR. I've updated the comment per your request and changed the target to master. However, I now see 7,833 files changed which is obviously wrong.

@jtibshirani
Copy link
Contributor

My apologies, I now see that we have a different workflow for docs updates that were initiated directly from the website. Let's switch the branch back to 6.2, and I'll merge after the build passes.

@demisx demisx changed the base branch from master to 6.2 June 4, 2018 19:31
@demisx
Copy link
Contributor Author

demisx commented Jun 4, 2018

No worries. Done. Would really help if adjusting basic content in docs followed the simplest flow possible, thus encouraging more people to contribute with improvements. 👍

@jtibshirani jtibshirani merged commit 51fbf8a into elastic:6.2 Jun 4, 2018
jtibshirani pushed a commit that referenced this pull request Jun 4, 2018
@demisx @jtibshirani
Update get.asciidoc (#31084)
4bf4377 
Fix typo

(cherry picked from commit 51fbf8a)
jtibshirani pushed a commit that referenced this pull request Jun 4, 2018
@demisx @jtibshirani
Update get.asciidoc (#31084)
74f374b 
Fix typo

(cherry picked from commit 51fbf8a)
jtibshirani pushed a commit that referenced this pull request Jun 4, 2018
@demisx @jtibshirani
Update get.asciidoc (#31084)
c7c0acc 
Fix typo

(cherry picked from commit 51fbf8a)
martijnvg added a commit that referenced this pull request Jun 5, 2018
@martijnvg
Merge remote-tracking branch 'es/master' into ccr
530089f 
* es/master:
  Take into account the return value of TcpTransport.readMessageLength(...) in Netty4SizeHeaderFrameDecoder
  Move caching of the size of a directory to `StoreDirectory`. (#30581)
  Clarify docs about boolean operator precedence. (#30808)
  Docs: remove notes on sparsity. (#30905)
  Fix MatchPhrasePrefixQueryBuilderTests#testPhraseOnFieldWithNoTerms
  run overflow forecast a 2nd time as regression test for elastic/ml-cpp#110 (#30969)
  Improve documentation of dynamic mappings. (#30952)
  Decouple MultiValueMode. (#31075)
  Docs: Clarify constraints on scripted similarities. (#31076)
  Update get.asciidoc (#31084)
martijnvg added a commit that referenced this pull request Jun 5, 2018
@martijnvg
Merge remote-tracking branch 'es/6.x' into ccr-6.x
51963e5 
* es/6.x:
  Fix compil after backport
  Fix index prefixes to work with span_multi (#31066)
  Delete superfluous UpdateRequest test
  Disable MultiMatchQueryBuilderTests.
  Disable UpdateRequestTest#testUnknownFieldParsing.
  Update get.asciidoc (#31084)
  When the 'strict' mapping option is enabled, make sure to validate split_queries_on_whitespace.
  Transport client: Don't validate node in handshake (#30737) (#31080)
  In the internal highlighter APIs, use the field type as opposed to the mapper. (#31039)
  [DOCS] Removes redundant authorization pages
  Upgrade to Lucene-7.4.0-snapshot-0a7c3f462f (#31073)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v6.2.0 v6.3.0 v6.4.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@demisx @jtibshirani @elasticmachine @colings86