-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Minor fix for SubmitAsyncSearchRequest.keepOnCompletion javadoc #54325
Merged
cbuescher
merged 2 commits into
elastic:master
from
cbuescher:docs-keepOnCompletion-correction
Mar 27, 2020
Merged
[Doc] Minor fix for SubmitAsyncSearchRequest.keepOnCompletion javadoc #54325
cbuescher
merged 2 commits into
elastic:master
from
cbuescher:docs-keepOnCompletion-correction
Mar 27, 2020
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semantics and the default value for this parameter have changed, adapting the javadoc accordingly.
cbuescher
added
>docs
General docs changes
:Search/Search
Search-related issues that do not fall into other categories
v8.0.0
v7.8.0
v7.7.1
labels
Mar 27, 2020
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-search (:Search/Search) |
@elasticmachine update branch |
javanna
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for catching it @cbuescher , LGTM
cbuescher
pushed a commit
that referenced
this pull request
Mar 27, 2020
#54325) The semantics and the default value for this parameter have changed, adapting the javadoc accordingly.
cbuescher
pushed a commit
that referenced
this pull request
Mar 27, 2020
#54325) The semantics and the default value for this parameter have changed, adapting the javadoc accordingly.
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Mar 30, 2020
* upstream/master: (447 commits) Adjust BWC version on node roles being sorted Deprecate node local storage setting (elastic#54374) Remove Unused BaseNodeRequest (elastic#54323) Decouple environment from DiscoveryNode (elastic#54373) Ensure that the output of node roles are sorted (elastic#54376) Do not stash environment in security (elastic#54372) Do not stash environment in machine learning (elastic#54371) Clean up how pipeline aggs check for multi-bucket (elastic#54161) Remove toString from Painless user tree nodes (elastic#54117) Docs: Use splitOnToken instead of custom function (elastic#48408) bwc: enable script cache in node stats (elastic#54362) bwc: Mute for script cache in node stats (elastic#54359) Test to enforce response to invalid data stream names Scripting: Use randomValueOtherThan in stats test (elastic#54356) Move transport decoding and aggregation to server (elastic#48263) Mute ScriptServiceTests.testContextCacheStats (elastic#54352) Improve checkstyle performance and readability (elastic#54308) Disable Gradle daemon when executing Windows packaging tests (elastic#54316) [Docs] Minor fix for SubmitAsyncSearchRequest.keepOnCompletion javadoc (elastic#54325) [DOCS] Fix typos in top metrics agg docs (elastic#54299) ... Conflicts: server/src/main/java/org/elasticsearch/index/IndexModule.java server/src/main/java/org/elasticsearch/index/IndexService.java server/src/main/java/org/elasticsearch/indices/IndicesService.java server/src/test/java/org/elasticsearch/index/IndexModuleTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>docs
General docs changes
:Search/Search
Search-related issues that do not fall into other categories
v7.7.0
v7.8.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics and the default value for this parameter have changed, adapting
the javadoc accordingly.