Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Minor fix for SubmitAsyncSearchRequest.keepOnCompletion javadoc #54325

Merged
merged 2 commits into from
Mar 27, 2020
Merged

[Doc] Minor fix for SubmitAsyncSearchRequest.keepOnCompletion javadoc #54325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eef81d0
[Doc] Minor fix for SubmitAsyncSearchRequest.keepOnCompletion javadoc
Mar 27, 2020
666f2b0
Merge branch 'master' into docs-keepOnCompletion-correction
elasticmachine Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...gh-level/src/main/java/org/elasticsearch/client/asyncsearch/SubmitAsyncSearchRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,14 @@ public void setWaitForCompletionTimeout(TimeValue waitForCompletionTimeout) {
}

/**
* Returns whether the resource resource should be removed on completion or failure (defaults to true).
* Returns whether the resource resource should be kept on completion or failure (defaults to false).
*/
public Boolean isKeepOnCompletion() {
return keepOnCompletion;
}

/**
* Determines if the resource should be removed on completion or failure (defaults to true).
* Determines if the resource should be kept on completion or failure (defaults to false).
*/
public void setKeepOnCompletion(boolean keepOnCompletion) {
this.keepOnCompletion = keepOnCompletion;
Expand Down
10 changes: 7 additions & 3 deletions ...re/src/main/java/org/elasticsearch/xpack/core/search/action/SubmitAsyncSearchRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public SearchRequest getSearchRequest() {
}

/**
* Should the resource be removed on completion or failure (defaults to true).
* Should the resource be kept on completion or failure (defaults to false).
*/
public SubmitAsyncSearchRequest setKeepOnCompletion(boolean value) {
this.keepOnCompletion = value;
Expand Down Expand Up @@ -162,8 +162,12 @@ public boolean shouldCancelChildrenOnCancellation() {

@Override
public boolean equals(Object o) {
if (this == o) return true;
if (o == null || getClass() != o.getClass()) return false;
if (this == o) {
return true;
}
if (o == null || getClass() != o.getClass()) {
return false;
}
SubmitAsyncSearchRequest request1 = (SubmitAsyncSearchRequest) o;
return keepOnCompletion == request1.keepOnCompletion &&
waitForCompletionTimeout.equals(request1.waitForCompletionTimeout) &&
Expand Down