Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: [apm] link to master in n.x branches #56538

Merged
merged 2 commits into from
May 11, 2020
Merged

docs: [apm] link to master in n.x branches #56538

merged 2 commits into from
May 11, 2020

Conversation

bmorelli25
Copy link
Member

Conditionally changes APM Server documentation links to point to master from ES 7.x docs. See #56537 for additional context.

I'll open a separate PR that cherry-picks this to 7.x. This does not need to be backported.

@bmorelli25 bmorelli25 added the Team:Docs Meta label for docs team label May 11, 2020
@bmorelli25 bmorelli25 requested a review from a team May 11, 2020 19:04
@bmorelli25 bmorelli25 self-assigned this May 11, 2020
This was referenced May 11, 2020
Merged
Closed
@jrodewig jrodewig added :Docs >docs General docs changes labels May 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (:Docs)

jrodewig
jrodewig reviewed May 11, 2020
View reviewed changes
docs/Versions.asciidoc Outdated Show resolved Hide resolved
jrodewig
jrodewig approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bmorelli25 bmorelli25 merged commit f61d3d8 into elastic:master May 11, 2020
@bmorelli25 bmorelli25 deleted the add-apm-if-directive-m branch May 11, 2020 20:42
@bmorelli25 bmorelli25 mentioned this pull request Dec 7, 2021
Merged
jrodewig pushed a commit that referenced this pull request Dec 7, 2021
@bmorelli25
[DOCS] Remove outdated APM ifeval (#81402)
0ac57d3 
Removes the old `ifeval` for links to 7.x APM documentation. 7.x no longer exists, so this code isn't needed.

Originally added in #56538.
elasticsearchmachine pushed a commit that referenced this pull request Dec 7, 2021
@jrodewig @bmorelli25
[DOCS] Remove outdated APM ifeval (#81402) (#81439)
fd8702c 
Removes the old `ifeval` for links to 7.x APM documentation. 7.x no longer exists, so this code isn't needed.

Originally added in #56538.

Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Dec 7, 2021
@jrodewig @bmorelli25
[DOCS] Remove outdated APM ifeval (#81402) (#81438)
2a9583c 
Removes the old `ifeval` for links to 7.x APM documentation. 7.x no longer exists, so this code isn't needed.

Originally added in #56538.

Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
@bmorelli25
Copy link
Member Author

Thanks, y'all! 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

Assignees

@bmorelli25 bmorelli25

Labels
>docs General docs changes Team:Docs Meta label for docs team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmorelli25 @elasticmachine @jrodewig @jakelandis