Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove old APM ifeval #81402

Merged
merged 1 commit into from
Dec 7, 2021
Merged

docs: remove old APM ifeval #81402

merged 1 commit into from
Dec 7, 2021

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Dec 7, 2021 •
edited
Loading

Removes the old ifeval for links to 7.x APM documentation. 7.x no longer exists, so this code isn't needed.

Originally added in #56538.

@elasticsearchmachine elasticsearchmachine added v8.1.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 7, 2021
@bmorelli25 bmorelli25 mentioned this pull request Dec 7, 2021
Closed
25 tasks
@bmorelli25 bmorelli25 added v7.16.0 v8.0.0 >docs General docs changes labels Dec 7, 2021
@bmorelli25 bmorelli25 requested a review from a team December 7, 2021 04:55
@bmorelli25 bmorelli25 marked this pull request as ready for review December 7, 2021 04:56
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Dec 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@bmorelli25 bmorelli25 added Team:Docs Meta label for docs team and removed Team:Docs Meta label for docs team labels Dec 7, 2021
lockewritesdocs
lockewritesdocs approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 It also seems that the only usage of these variables in the Elasticsearch docs repo is within this file.

@jrodewig jrodewig merged commit 0ac57d3 into master Dec 7, 2021
@jrodewig jrodewig deleted the bmorelli25-patch-1 branch December 7, 2021 14:21
This was referenced Dec 7, 2021
Merged
Merged
elasticsearchmachine pushed a commit that referenced this pull request Dec 7, 2021
@jrodewig @bmorelli25
[DOCS] Remove outdated APM ifeval (#81402) (#81439)
fd8702c 
Removes the old `ifeval` for links to 7.x APM documentation. 7.x no longer exists, so this code isn't needed.

Originally added in #56538.

Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Dec 7, 2021
@jrodewig @bmorelli25
[DOCS] Remove outdated APM ifeval (#81402) (#81438)
2a9583c 
Removes the old `ifeval` for links to 7.x APM documentation. 7.x no longer exists, so this code isn't needed.

Originally added in #56538.

Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lockewritesdocs lockewritesdocs lockewritesdocs approved these changes

Assignees
No one assigned
Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v7.16.0 v8.0.0-rc2 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bmorelli25 @elasticmachine @lockewritesdocs @pugnascotia @jrodewig @elasticsearchmachine