[ML] write warning if configured memory limit is too low for analytics job #61505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
.../src/main/java/org/elasticsearch/xpack/ml/action/TransportStartDataFrameAnalyticsAction.java
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/job/messages/Messages.java
Outdated
Show resolved
Hide resolved
benwtrent
commented
Aug 25, 2020
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/job/messages/Messages.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/xpack/ml/action/TransportStartDataFrameAnalyticsAction.java
Show resolved
Hide resolved
…on/TransportStartDataFrameAnalyticsAction.java
…ml/job/messages/Messages.java
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Aug 25, 2020
…s job (elastic#61505) Having `_start` fail when the configured memory limit is too low can be frustrating. We should instead warn the user that their job might not run properly if their configured limit is too low. It might be that our estimate is too high, and their configured limit works just fine.
benwtrent
added a commit
that referenced
this pull request
Aug 26, 2020
…alytics job (#61505) (#61528) Backports the following commits to 7.x: [ML] write warning if configured memory limit is too low for analytics job (#61505) Having `_start` fail when the configured memory limit is too low can be frustrating. We should instead warn the user that their job might not run properly if their configured limit is too low. It might be that our estimate is too high, and their configured limit works just fine.
benwtrent
added a commit
to elastic/ml-cpp
that referenced
this pull request
Sep 1, 2020
…er than predicted memory usage (#1465) From the management side, we allow users to update configured memory limits after the analytics configuration has started. To help users with their workflow, we should allow analytics processes to attempt to run even if the configured memory limit is lower than our memory estimate. related to: elastic/elasticsearch#61505
benwtrent
added a commit
to elastic/ml-cpp
that referenced
this pull request
Sep 1, 2020
…er than predicted memory usage (#1465) (#1467) From the management side, we allow users to update configured memory limits after the analytics configuration has started. To help users with their workflow, we should allow analytics processes to attempt to run even if the configured memory limit is lower than our memory estimate. related to: elastic/elasticsearch#61505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
_startfail when the configured memory limit is too low can be frustrating.We should instead warn the user that their job might not run properly if their configured limit is too low.
It might be that our estimate is too high, and their configured limit works just fine.