Remove setNextScore in SearchScript. #6864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import java.util.Map; | ||
|
|
||
| public class ScriptScoreFunction extends ScoreFunction { | ||
|
|
||
| static class CannedScorer extends Scorer { |
|
I left some comments... look good in general |
|
LGTM, we should make sure we fix mvel as well, not just groovy |
|
@kimchy Mvel it removed in master that is why it's not in the PR it's still on 1.x so I guess ryan is fixing it once he is porting the commit |
While it would be nice to do this all the way up the chain (into score functions), this at least removes the weird dual setNextScore/setScorer for SearchScripts.
|
Yes, I will fix mvel in 1.x when I backport to there. |
rjernst
added a commit
that referenced
this pull request
Jul 16, 2014
While it would be nice to do this all the way up the chain (into score functions), this at least removes the weird dual setNextScore/setScorer for SearchScripts. closes #6864
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 16, 2014
…er script engines to use. With the removal of setNextScore in elastic#6864, script engines must use the Scorer to find the score of a document. The DocLookup is updated appropriately to do this, but most script engines require a Number to be bound for numeric variables. Groovy already had an encapsulation for this funtionality, and this moves it out to be shared with other script engines.
rjernst
added a commit
that referenced
this pull request
Jul 16, 2014
With the removal of setNextScore in #6864, script engines must use the Scorer to find the score of a document. The DocLookup is updated appropriately to do this, but most script engines require a Number to be bound for numeric variables. Groovy already had an encapsulation for this funtionality, and this moves it out to be shared with other script engines. closes #6898
rjernst
added a commit
that referenced
this pull request
Jul 17, 2014
With the removal of setNextScore in #6864, script engines must use the Scorer to find the score of a document. The DocLookup is updated appropriately to do this, but most script engines require a Number to be bound for numeric variables. Groovy already had an encapsulation for this funtionality, and this moves it out to be shared with other script engines. closes #6898
clintongormley
changed the title
brwe
added a commit
to elastic/elasticsearch-lang-javascript
that referenced
this pull request
Oct 7, 2014
Due to a change in elasticsearch 1.4.0, we need to apply a similar patch here. See elastic/elasticsearch#6864 See elastic/elasticsearch#7819 Closes #23. (cherry picked from commit 5e5c373)
brwe
added a commit
to elastic/elasticsearch-lang-javascript
that referenced
this pull request
Oct 7, 2014
Due to a change in elasticsearch 1.4.0, we need to apply a similar patch here. See elastic/elasticsearch#6864 See elastic/elasticsearch#7819 Closes #23.
brwe
added a commit
to elastic/elasticsearch-lang-javascript
that referenced
this pull request
Oct 7, 2014
Due to a change in elasticsearch 1.4.0, we need to apply a similar patch here. See elastic/elasticsearch#6864 See elastic/elasticsearch#7819 Closes #23. (cherry picked from commit 5e5c373)
brwe
added a commit
to elastic/elasticsearch-lang-python
that referenced
this pull request
Oct 7, 2014
Due to a change in elasticsearch 1.4.0, we need to apply a similar patch here. See elastic/elasticsearch#6864 See elastic/elasticsearch#7819 Closes #16. Closes #21.
brwe
added a commit
to elastic/elasticsearch-lang-python
that referenced
this pull request
Oct 7, 2014
Due to a change in elasticsearch 1.4.0, we need to apply a similar patch here. See elastic/elasticsearch#6864 See elastic/elasticsearch#7819 Closes #16. Closes #21. (cherry picked from commit cd7756c)
brwe
added a commit
to elastic/elasticsearch-lang-python
that referenced
this pull request
Oct 7, 2014
Due to a change in elasticsearch 1.4.0, we need to apply a similar patch here. See elastic/elasticsearch#6864 See elastic/elasticsearch#7819 Closes #16. Closes #21. (cherry picked from commit cd7756c)
This was referenced Nov 10, 2014
clintongormley
added
the
:Core/Infra/Scripting
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it would be nice to do this all the way up the chain (into
score functions), this at least removes the weird dual
setNextScore/setScorer for SearchScripts.