Make ScoreAccessor utility class publicly available for other script engines #6898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er script engines to use. With the removal of setNextScore in elastic#6864, script engines must use the Scorer to find the score of a document. The DocLookup is updated appropriately to do this, but most script engines require a Number to be bound for numeric variables. Groovy already had an encapsulation for this funtionality, and this moves it out to be shared with other script engines.
|
looks good |
rjernst
added a commit
that referenced
this pull request
Jul 17, 2014
With the removal of setNextScore in #6864, script engines must use the Scorer to find the score of a document. The DocLookup is updated appropriately to do this, but most script engines require a Number to be bound for numeric variables. Groovy already had an encapsulation for this funtionality, and this moves it out to be shared with other script engines. closes #6898
clintongormley
changed the title
clintongormley
added
the
:Core/Infra/Scripting
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the removal of setNextScore in #6864, script engines must use
the Scorer to find the score of a document. The DocLookup is updated
appropriately to do this, but most script engines require a Number to be
bound for numeric variables. Groovy already had an encapsulation for
this funtionality, and this moves it out to be shared with other script
engines.