Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test for sample aggragator #77807

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Sep 15, 2021

Adds and integration test for the sample aggregator. It's a fairly
simple aggregator - you can only chose how many documents it samples.

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations v8.0.0 v7.16.0 labels Sep 15, 2021
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Sep 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, LGTM

Adds and integration test for the sample aggregator. It's a fairly
simple aggregator - you can only chose how many documents it samples.
@nik9000 nik9000 added auto-backport-and-merge auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) and removed auto-backport-and-merge labels Sep 15, 2021
@elasticsearchmachine elasticsearchmachine merged commit 9a545fb into elastic:master Sep 15, 2021
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Sep 15, 2021
Adds and integration test for the sample aggregator. It's a fairly
simple aggregator - you can only chose how many documents it samples.
elasticsearchmachine pushed a commit that referenced this pull request Sep 15, 2021
Adds and integration test for the sample aggregator. It's a fairly
simple aggregator - you can only chose how many documents it samples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants