-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comprehensive aggregation REST tests #26220
Comments
Adds some REST tests for avg/min/max/sum metric aggregations Related to #26220
Adds some REST tests for avg/min/max/sum metric aggregations Related to #26220
Adds some REST tests for avg/min/max/sum metric aggregations Related to #26220
Question: do we want to have these as yaml tests so the language clients can run them too? Or shall we consider making them java tests that se the low-level REST client instead? |
I was targeting the yaml tests so that clients could also run them, figured that would provide the widest benefit to new tests (since basically none of the clients do any body testing at all, it may smoke out some issues). And yaml tests are sometimes easier to write :) But I could be convinced either way. What do you think? |
I am fine with moving forward with yaml tests, I don't have a strong opinion, I just wanted to make sure that we consider writing java tests too. |
There's a separate test for each TDigest and HDR Histo, to keep things clean. Related to elastic#26220
There's a separate test for each TDigest and HDR Histo, to keep things clean. Related to #26220
There's a separate test for each TDigest and HDR Histo, to keep things clean. Related to #26220
There's a separate test for each TDigest and HDR Histo, to keep things clean. Related to #26220
cc @elastic/es-search-aggs |
The numbering is fairly arbitrary. Feel free to just pick the next available multiple of ten and start there. I believe there are historical reasons for it, but at this point it's mostly tradition. Thanks for helping out! |
Reminds me of writing basic in middle school. |
I can't tell if that's a point in favor of or against continuing the practice. |
Adds REST tests for the `cumulative_cardinality` and `cumulative_sum` pipeline aggregations. This gives us forwards and backwards compatibility tests for these aggs as well as mixed version cluster tests for these aggs. Relates to elastic#26220
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Adds REST tests for the `cumulative_cardinality` and `cumulative_sum` pipeline aggregations. This gives us forwards and backwards compatibility tests for these aggs as well as mixed version cluster tests for these aggs. Relates to elastic#26220
Adds REST tests for the `percentiles_bucket` pipeline bucket aggregation. This gives us forwards and backwards compatibility tests for these aggs as well as mixed version cluster tests for these aggs. Relates to elastic#26220
This cleans up the derivative pipeline agg in a few days: 1. Moves it to the `aggregations` module ala elastic#90283 2. Drops the ceremonial interface from the result ala elastic#82273 3. Adds comprehensive REST layer tests for it ala elastic#26220 4. Removes some `ESIntegTestCase tests` that duplicated those in the `AggregatorTestCase`.
This cleans up the derivative pipeline agg in a few days: 1. Moves it to the `aggregations` module ala #90283 2. Drops the ceremonial interface from the result ala #82273 3. Adds comprehensive REST layer tests for it ala #26220 4. Removes some `ESIntegTestCase tests` that duplicated those in the `AggregatorTestCase`.
This moves the bucket selector aggregation to the aggregations module and ports all of it's ESIntegTestCase tests to REST tests which gets us mixed cluster testing. Relates to elastic#26220 Relates to elastic#90283
The missing tests were derived from [rate aggregation documentation]( https://www.elastic.co/guide/en/elasticsearch/reference/current/search -aggregations-metrics-rate-aggregation.html). Related to elastic#26220.
The missing tests were derived from [rate aggregation documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-metrics-rate-aggregation.html): - Composite aggregation - Rate with mode set to `value_count` - Aggregation on a runtime field using script Related to #26220
The added tests cover the [documented](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-metrics-scripted-metric-aggregation.html) functionality. Related to elastic#26220.
The added tests cover the [documented](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-metrics-scripted-metric-aggregation.html) functionality. Related to #26220.
Pinging @elastic/es-analytical-engine (Team:Analytics) |
There are only a few REST tests that verify the body of aggregation results. We should have a more comprehensive suite of tests that check the body under a variety of conditions and options.
Metrics:
Bucketing
Geo Distance Aggregation (Craig)- cancelled in favour of ES|QL featuresterms
but the agg sees less use)Pipeline
moving_fn
agg #90012The text was updated successfully, but these errors were encountered: