Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive aggregation REST tests #26220

Open
68 of 69 tasks
polyfractal opened this issue Aug 15, 2017 · 13 comments
Open
68 of 69 tasks

Comprehensive aggregation REST tests #26220

polyfractal opened this issue Aug 15, 2017 · 13 comments
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >tech debt >test Issues or PRs that are addressing/adding tests

Comments

@polyfractal
Copy link
Contributor

polyfractal commented Aug 15, 2017

There are only a few REST tests that verify the body of aggregation results. We should have a more comprehensive suite of tests that check the body under a variety of conditions and options.

Metrics:

Bucketing

Pipeline

@polyfractal polyfractal added :Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests labels Aug 15, 2017
@polyfractal polyfractal self-assigned this Aug 15, 2017
polyfractal added a commit to polyfractal/elasticsearch that referenced this issue Aug 15, 2017
polyfractal added a commit that referenced this issue Aug 16, 2017
Adds some REST tests for avg/min/max/sum metric aggregations

Related to #26220
polyfractal added a commit that referenced this issue Aug 16, 2017
Adds some REST tests for avg/min/max/sum metric aggregations

Related to #26220
polyfractal added a commit that referenced this issue Aug 16, 2017
Adds some REST tests for avg/min/max/sum metric aggregations

Related to #26220
polyfractal added a commit to polyfractal/elasticsearch that referenced this issue Aug 16, 2017
@javanna
Copy link
Member

javanna commented Aug 17, 2017

Question: do we want to have these as yaml tests so the language clients can run them too? Or shall we consider making them java tests that se the low-level REST client instead?

@polyfractal
Copy link
Contributor Author

I was targeting the yaml tests so that clients could also run them, figured that would provide the widest benefit to new tests (since basically none of the clients do any body testing at all, it may smoke out some issues). And yaml tests are sometimes easier to write :)

But I could be convinced either way. What do you think?

@javanna
Copy link
Member

javanna commented Aug 17, 2017

I am fine with moving forward with yaml tests, I don't have a strong opinion, I just wanted to make sure that we consider writing java tests too.

polyfractal added a commit that referenced this issue Aug 17, 2017
… aggs (#26239)

* Add REST tests for value_count, stats, extended_stats and cardinality aggs

Also updates the document type of of other agg REST tests to `doc`

Related to #26220
polyfractal added a commit that referenced this issue Aug 17, 2017
… aggs (#26239)

* Add REST tests for value_count, stats, extended_stats and cardinality aggs

Also updates the document type of of other agg REST tests to `doc`

Related to #26220
polyfractal added a commit that referenced this issue Aug 17, 2017
… aggs (#26239)

* Add REST tests for value_count, stats, extended_stats and cardinality aggs

Also updates the document type of of other agg REST tests to `doc`

Related to #26220
polyfractal added a commit to polyfractal/elasticsearch that referenced this issue Aug 17, 2017
There's a separate test for each TDigest and HDR Histo,
to keep things clean.

Related to elastic#26220
polyfractal added a commit that referenced this issue Aug 18, 2017
There's a separate test for each TDigest and HDR Histo,
to keep things clean.

Related to #26220
polyfractal added a commit that referenced this issue Aug 18, 2017
There's a separate test for each TDigest and HDR Histo,
to keep things clean.

Related to #26220
polyfractal added a commit that referenced this issue Aug 18, 2017
There's a separate test for each TDigest and HDR Histo,
to keep things clean.

Related to #26220
polyfractal added a commit to polyfractal/elasticsearch that referenced this issue Oct 26, 2017
polyfractal added a commit to polyfractal/elasticsearch that referenced this issue Nov 20, 2017
polyfractal added a commit that referenced this issue Nov 20, 2017
@markharwood
Copy link
Contributor

cc @elastic/es-search-aggs

@rjernst rjernst added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 4, 2020
@not-napoleon
Copy link
Member

The numbering is fairly arbitrary. Feel free to just pick the next available multiple of ten and start there. I believe there are historical reasons for it, but at this point it's mostly tradition. Thanks for helping out!

@nik9000
Copy link
Member

nik9000 commented Jul 25, 2022

I believe there are historical reasons for it, but at this point it's mostly tradition.

Reminds me of writing basic in middle school.

@not-napoleon
Copy link
Member

Reminds me of writing basic in middle school.

I can't tell if that's a point in favor of or against continuing the practice.

nik9000 added a commit to nik9000/elasticsearch that referenced this issue Jul 29, 2022
Adds REST tests for the `cumulative_cardinality` and `cumulative_sum`
pipeline aggregations. This gives us forwards and backwards compatibility
tests for these aggs as well as mixed version cluster tests for these
aggs.

Relates to elastic#26220
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

pull bot pushed a commit to NOUIY/elasticsearch that referenced this issue Aug 17, 2022
Adds REST tests for the `cumulative_cardinality` and `cumulative_sum`
pipeline aggregations. This gives us forwards and backwards compatibility
tests for these aggs as well as mixed version cluster tests for these
aggs.

Relates to elastic#26220
pull bot pushed a commit to NOUIY/elasticsearch that referenced this issue Aug 17, 2022
Adds REST tests for the `percentiles_bucket` pipeline bucket
aggregation. This gives us forwards and backwards compatibility tests
for these aggs as well as mixed version cluster tests for these aggs.

Relates to elastic#26220
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Oct 19, 2022
This cleans up the derivative pipeline agg in a few days:
1. Moves it to the `aggregations` module ala elastic#90283
2. Drops the ceremonial interface from the result ala elastic#82273
3. Adds comprehensive REST layer tests for it ala elastic#26220
4. Removes some `ESIntegTestCase tests` that duplicated those in the
   `AggregatorTestCase`.
nik9000 added a commit that referenced this issue Oct 31, 2022
This cleans up the derivative pipeline agg in a few days:
1. Moves it to the `aggregations` module ala #90283
2. Drops the ceremonial interface from the result ala #82273
3. Adds comprehensive REST layer tests for it ala #26220
4. Removes some `ESIntegTestCase tests` that duplicated those in the
   `AggregatorTestCase`.
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Nov 7, 2022
This moves the bucket selector aggregation to the aggregations module
and ports all of it's ESIntegTestCase tests to REST tests which gets us
mixed cluster testing.

Relates to elastic#26220
Relates to elastic#90283
elasticsearchmachine pushed a commit that referenced this issue Nov 10, 2022
This moves the bucket selector aggregation to the aggregations module
and ports all of it's ESIntegTestCase tests to REST tests which gets us
mixed cluster testing.

Relates to #26220 Relates to #90283
martijnvg added a commit to martijnvg/elasticsearch that referenced this issue Apr 2, 2023
martijnvg added a commit that referenced this issue Apr 11, 2023
kkrik-es added a commit to kkrik-es/elasticsearch that referenced this issue Apr 26, 2023
The missing tests were derived from [rate aggregation documentation](
https://www.elastic.co/guide/en/elasticsearch/reference/current/search
-aggregations-metrics-rate-aggregation.html).

Related to elastic#26220.
elasticsearchmachine pushed a commit that referenced this issue Apr 26, 2023
The missing tests were derived from [rate aggregation
documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-metrics-rate-aggregation.html):

- Composite aggregation
- Rate with mode set to `value_count`
- Aggregation on a runtime field using script

Related to #26220
kkrik-es added a commit to kkrik-es/elasticsearch that referenced this issue Apr 27, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >tech debt >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

No branches or pull requests

12 participants