-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New GeoHexGrid aggregation #82924
New GeoHexGrid aggregation #82924
Conversation
This commit introduces a new geogrid aggregation called GeoHexGridAggregation that is based in Uber h3 grid. It only supports geo_point fields.
Pinging @elastic/es-analytics-geo (Team:Analytics) |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iverase! I left some suggestions and comments. I'd like to take another look, mostly to ensure I didn't introduce any errors in my review.
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/aggregations/bucket/geohexgrid-aggregation.asciidoc
Outdated
Show resolved
Hide resolved
…idoc Co-authored-by: James Rodewig <james.rodewig@elastic.co>
…idoc Co-authored-by: James Rodewig <james.rodewig@elastic.co>
…idoc Co-authored-by: James Rodewig <james.rodewig@elastic.co>
…idoc Co-authored-by: James Rodewig <james.rodewig@elastic.co>
…idoc Co-authored-by: James Rodewig <james.rodewig@elastic.co>
…idoc Co-authored-by: James Rodewig <james.rodewig@elastic.co>
…idoc Co-authored-by: James Rodewig <james.rodewig@elastic.co>
…idoc Co-authored-by: James Rodewig <james.rodewig@elastic.co>
Hi @iverase, I've created a changelog YAML for you. |
Hi @iverase, I've updated the changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. All the interesting stuff is in GeoHexCellIdSource
and it works like the other similar things. @imotov should also have a look, but it seems right to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Getting a 404 on the doc. Would love to take a look and prepare what we have on the horizon for GEO. |
Hi @jmp601, this work will be part of our upcoming 8.1.0 release. The docs for that release are currently in our |
This commit introduces a new geogrid aggregation called GeoHexGridAggregation that
is based in Uber h3 grid. It only supports geo_point fields.
Docs preview
https://elasticsearch_82924.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/search-aggregations-bucket-geohexgrid-aggregation.html