Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST tests for top_hits #83690

Merged
merged 5 commits into from
Feb 28, 2022
Merged

REST tests for top_hits #83690

merged 5 commits into from
Feb 28, 2022

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Feb 8, 2022

This adds a pile of extra REST tests for the top_hits aggregation
which is useful because this is how we do mixed version cluster testing.
And backwards compatibility testing. And forwards compatibility testing.

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations v8.2.0 labels Feb 8, 2022
@nik9000 nik9000 requested a review from not-napoleon February 8, 2022 22:15
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 8, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@nik9000
Copy link
Member Author

nik9000 commented Feb 8, 2022

This is nowhere near exhaustive of the features that top_hits supports because it inherits many things from _search. But it's much better than we had.

This adds a pile of extra REST tests for the `top_hits` aggregation
which is useful because this is how we do mixed version cluster testing.
And backwards compatibility testing. And forwards compatibility testing.
Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should this get backported to 7.17?

@nik9000
Copy link
Member Author

nik9000 commented Feb 28, 2022

LGTM. Should this get backported to 7.17?

It can. I hadn't planned on it just for time's sake. But I'll see if the backport robot can do it.

@nik9000 nik9000 added v7.17.2 v8.0.2 v8.1.1 auto-backport Automatically create backport pull requests when merged and removed v8.0.2 labels Feb 28, 2022
@nik9000 nik9000 merged commit 6309d64 into elastic:master Feb 28, 2022
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Feb 28, 2022
This adds a pile of extra REST tests for the `top_hits` aggregation
which is useful because this is how we do mixed version cluster testing.
And backwards compatibility testing. And forwards compatibility testing.
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Feb 28, 2022
This adds a pile of extra REST tests for the `top_hits` aggregation
which is useful because this is how we do mixed version cluster testing.
And backwards compatibility testing. And forwards compatibility testing.
nik9000 added a commit that referenced this pull request Feb 28, 2022
This adds a pile of extra REST tests for the `top_hits` aggregation
which is useful because this is how we do mixed version cluster testing.
And backwards compatibility testing. And forwards compatibility testing.
nik9000 added a commit that referenced this pull request Feb 28, 2022
* REST tests for top_hits (#83690)

This adds a pile of extra REST tests for the `top_hits` aggregation
which is useful because this is how we do mixed version cluster testing.
And backwards compatibility testing. And forwards compatibility testing.

* After 7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v7.17.2 v8.1.1 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants