-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST tests for top_hits #83690
REST tests for top_hits #83690
Conversation
Pinging @elastic/es-analytics-geo (Team:Analytics) |
This is nowhere near exhaustive of the features that |
This adds a pile of extra REST tests for the `top_hits` aggregation which is useful because this is how we do mixed version cluster testing. And backwards compatibility testing. And forwards compatibility testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should this get backported to 7.17?
It can. I hadn't planned on it just for time's sake. But I'll see if the backport robot can do it. |
This adds a pile of extra REST tests for the `top_hits` aggregation which is useful because this is how we do mixed version cluster testing. And backwards compatibility testing. And forwards compatibility testing.
This adds a pile of extra REST tests for the `top_hits` aggregation which is useful because this is how we do mixed version cluster testing. And backwards compatibility testing. And forwards compatibility testing.
* REST tests for top_hits (#83690) This adds a pile of extra REST tests for the `top_hits` aggregation which is useful because this is how we do mixed version cluster testing. And backwards compatibility testing. And forwards compatibility testing. * After 7.0
This adds a pile of extra REST tests for the
top_hits
aggregationwhich is useful because this is how we do mixed version cluster testing.
And backwards compatibility testing. And forwards compatibility testing.