Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST tests for variable width historam #84836

Merged
merged 4 commits into from
Mar 18, 2022

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Mar 9, 2022

This expands on the super basic REST tests for variable width histogram
with some ever so slightly less basic tests. They are still pretty
basic, but they do a good job of making sure that we don't break
backwards compatibility with the API.

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Analytics/Aggregations Aggregations v8.0.0 test-full-bwc Trigger full BWC version matrix tests v7.16.4 v8.2.0 v8.1.1 labels Mar 9, 2022
@nik9000 nik9000 requested a review from not-napoleon March 9, 2022 18:48
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 9, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

This expands on the super basic REST tests for variable width histogram
with some ever so slightly less basic tests. They are still pretty
basic, but they do a good job of making sure that we don't break
backwards compatibility with the API.
@nik9000
Copy link
Member Author

nik9000 commented Mar 9, 2022

@elasticmachine, update branch

@nik9000
Copy link
Member Author

nik9000 commented Mar 9, 2022

@elasticmachine update branch

@nik9000
Copy link
Member Author

nik9000 commented Mar 13, 2022

@elasticmachine update branch

@nik9000
Copy link
Member Author

nik9000 commented Mar 14, 2022

Blocked on #84869

Copy link
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn dnhatn added v8.1.2 and removed v8.1.1 labels Mar 17, 2022
@nik9000
Copy link
Member Author

nik9000 commented Mar 18, 2022

@elasticmachine update branch

@nik9000 nik9000 added v7.17.2 auto-backport Automatically create backport pull requests when merged and removed v7.16.4 labels Mar 18, 2022
@nik9000 nik9000 merged commit 7bb2cd9 into elastic:master Mar 18, 2022
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Mar 18, 2022
This expands on the super basic REST tests for variable width histogram
with some ever so slightly less basic tests. They are still pretty
basic, but they do a good job of making sure that we don't break
backwards compatibility with the API.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Mar 18, 2022
This expands on the super basic REST tests for variable width histogram
with some ever so slightly less basic tests. They are still pretty
basic, but they do a good job of making sure that we don't break
backwards compatibility with the API.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.0
7.17
8.1

nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Mar 18, 2022
This expands on the super basic REST tests for variable width histogram
with some ever so slightly less basic tests. They are still pretty
basic, but they do a good job of making sure that we don't break
backwards compatibility with the API.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nik9000 added a commit that referenced this pull request Mar 21, 2022
This expands on the super basic REST tests for variable width histogram
with some ever so slightly less basic tests. They are still pretty
basic, but they do a good job of making sure that we don't break
backwards compatibility with the API.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nik9000 added a commit that referenced this pull request Mar 21, 2022
This expands on the super basic REST tests for variable width histogram
with some ever so slightly less basic tests. They are still pretty
basic, but they do a good job of making sure that we don't break
backwards compatibility with the API.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@nik9000 nik9000 removed the v8.0.0 label Mar 21, 2022
@nik9000
Copy link
Member Author

nik9000 commented Mar 21, 2022

I've abandoned the 8.0 backport because that branch isn't happy at the moment and it doesn't bring any value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests test-full-bwc Trigger full BWC version matrix tests v7.17.2 v8.1.2 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants