Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More REST tests for geo_bounds aggregation #94742

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

craigtaverner
Copy link
Contributor

The cartesian_bounds tests were much more extensive, so we split them out and enhanced the geo_bounds test to cover the same scope, and then added additional tests for crossing the dateline with the wrap_longitude flag, something that cartesian_bounds did not support.

The cartesian_bounds tests were much more extensive, so we split
them out and enhanched the geo_bounds test to cover the same scope.
With and without the wrap_longitude toggle
@craigtaverner craigtaverner added >test Issues or PRs that are addressing/adding tests :Analytics/Geo Indexing, search aggregations of geo points and shapes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Mar 24, 2023
@craigtaverner craigtaverner requested a review from iverase March 24, 2023 16:22
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@craigtaverner craigtaverner merged commit eaa9b5e into elastic:main Mar 27, 2023
@craigtaverner craigtaverner deleted the rest_tests_geo_bounds branch October 20, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants