Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced REST tests for geo and cartesian centroid #94964

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

craigtaverner
Copy link
Contributor

Coverage increased to cover cases for:

  • centroid over points
  • centroid over shapes
  • centroid over points with filter
  • centroid over shapes with filter
  • centroid over points with grouping
  • centroid over shapes with grouping
  • centroid over shapes with grouping and filter

The last one was not done for points because the purpose of that test was primarily to validate the shape rules where centroids over GEOMETRYCOLLECTION would use only the highest dimensionality geometries for centroid calculation.

Coverage increased to cover cases for:

* centroid over points
* centroid over shapes
* centroid over points with filter
* centroid over shapes with filter
* centroid over points with grouping
* centroid over shapes with grouping
* centroid over shapes with grouping and filter

The last one was not done for points because the purpose of that test
was primarily to validate the shape rules where centroids over
GEOMETRYCOLLECTION would use only the highest dimensionality geometries
for centroid calculation.
@craigtaverner craigtaverner added >test Issues or PRs that are addressing/adding tests :Analytics/Geo Indexing, search aggregations of geo points and shapes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Mar 31, 2023
@craigtaverner craigtaverner requested a review from iverase March 31, 2023 16:55
@craigtaverner craigtaverner marked this pull request as ready for review March 31, 2023 16:55
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

So reduce risk of flakiness in aggregating over multiple documents
Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craigtaverner craigtaverner merged commit 56e50ab into elastic:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants