[EuiIcon] Fix missing style prop on custom icons (#6888)

* [EuiIcon] Fix missing `style` prop on custom icons + add `shouldRenderCustomStyles` test to ensure this doesn't regress * changelog
elastic · Jun 29, 2023 · 17e0d61 · 17e0d61
1 parent 1f8e4db
commit 17e0d61
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/src/components/icon/icon.test.tsx b/src/components/icon/icon.test.tsx
@@ -47,6 +47,7 @@ function testIcon(props: PropsOf<typeof EuiIcon>) {
 describe('EuiIcon', () => {
   test('is rendered', testIcon({ type: 'search', ...requiredProps }));
 
+  shouldRenderCustomStyles(<EuiIcon type="customImg" />);
   shouldRenderCustomStyles(<EuiIcon type="videoPlayer" />);
 
   describe('props', () => {

diff --git a/src/components/icon/icon.tsx b/src/components/icon/icon.tsx
@@ -288,6 +288,7 @@ export class EuiIconClass extends PureComponent<
           src={icon}
           className={classes}
           css={cssStyles}
+          style={style}
           tabIndex={tabIndex}
           {...(rest as ImgHTMLAttributes<HTMLImageElement>)}
         />

diff --git a/upcoming_changelogs/6888.md b/upcoming_changelogs/6888.md
@@ -0,0 +1,4 @@
+**Bug fixes**
+
+- Fixed `EuiIcon` not correctly passing the `style` prop custom `img` icons
+
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,4 @@
		Bug fixes

		- Fixed `EuiIcon` not correctly passing the `style` prop custom `img` icons