[EuiIcon] Fix missing style
prop on custom icons
#6888
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were pulling out
style
fromprops
but only passing it to svgEuiIcon
s and not imgEuiIcon
s.This would result in consumers passing in both a custom image and a
style
prop toEuiIcon
not having thatstyle
render whatsoever.(Bug discovered during
shouldRenderCustomStyles
work, pulling it out to its own PR for easy review and a separate changelog)QA
General checklist
and cypress tests