Notify parent component when a new item set changes the row selection (…

…#1086) * Notify parent component when a new item set changes the row selection * changelog
elastic · Aug 6, 2018 · 30013e9 · 30013e9
1 parent 4b535c2
commit 30013e9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,7 +8,7 @@
 - `EuiMutationObserver`'s `children` prop is no longer marked as required ([#1076](https://github.com/elastic/eui/pull/1076))
 - Fixed large drop shadows so they work on darker backgrounds ([#1079](https://github.com/elastic/eui/pull/1079))
 - Added `resize-observer-polyfill` as a dependency (was previously a devDependency) ([#1085](https://github.com/elastic/eui/pull/1085))
-
+- Fixed `EuiBasicTable` to inform its parent about a selection change triggered by a different set of `items` ([#1086](https://github.com/elastic/eui/pull/1086))
 
 ## [`3.3.0`](https://github.com/elastic/eui/tree/v3.3.0)
 

diff --git a/src/components/basic_table/basic_table.js b/src/components/basic_table/basic_table.js
@@ -199,7 +199,15 @@ export class EuiBasicTable extends Component {
       nextProps.items.findIndex(item => getItemId(item, itemId) === getItemId(selectedItem, itemId)) !== -1
     ));
 
-    return { selection };
+    if (selection.length !== prevState.selection.length) {
+      if (nextProps.selection.onSelectionChange) {
+        nextProps.selection.onSelectionChange(selection);
+      }
+
+      return { selection };
+    }
+
+    return null;
   }
 
   constructor(props) {