Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify parent component when a new item set changes the row selection #1086

Merged

Conversation

chandlerprall
Copy link
Contributor

Fixes #1083 by alerting EuiBasicTable's parent component when it changes the selection list in response to changing items.

@chandlerprall chandlerprall requested a review from cjcenizal August 3, 2018 18:01
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution! Tested locally and the bug in the EuiInMemoryTable docs is fixed. Code LGTM.

@chandlerprall chandlerprall merged commit 30013e9 into elastic:master Aug 6, 2018
@chandlerprall chandlerprall deleted the bug/1083-notify-selection-update branch August 6, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants