Skip to content

Commit

Permalink
Adding data-test-subj to super-date-picker (#1782)
Browse files Browse the repository at this point in the history
* Adding data-test-subj

Adding missing data-test-subj fields to missing objects on the relative tab

* Update CHANGELOG.md

* fixed spacing

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-Authored-By: marius-dr <marius-dr@users.noreply.github.com>

* Fix tabs to spaces
  • Loading branch information
marius-dr authored Apr 3, 2019
1 parent ce9849e commit 53ccece
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Converted `EuiFormErrorText` to TS ([#1772](https://github.com/elastic/eui/pull/1772))

- Added `data-test-subj`s to `EuiSuperDatePicker`'s `EuiRelativeTab` inputs ([#1782](https://github.com/elastic/eui/pull/1782))
**Bug fixes**

- Update ButtonIconColor type to provide all available options ([#1783](https://github.com/elastic/eui/pull/1783))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ export class EuiRelativeTab extends Component {
>
<EuiFieldNumber
aria-label="Count of"
data-test-subj={`superDatePickerRelativeDateInputNumber`}
value={this.state.count}
onChange={this.onCountChange}
isInvalid={isInvalid}
Expand All @@ -78,6 +79,7 @@ export class EuiRelativeTab extends Component {
<EuiFlexItem>
<EuiFormRow>
<EuiSelect
data-test-subj={`superDatePickerRelativeDateInputUnitSelector`}
value={this.state.unit}
options={relativeOptions}
onChange={this.onUnitChange}
Expand All @@ -90,6 +92,7 @@ export class EuiRelativeTab extends Component {
</EuiFormRow>
<EuiFormRow>
<EuiSwitch
data-test-subj={`superDatePickerRelativeDateRoundSwitch`}
label={`Round to the ${timeUnits[this.state.unit.substring(0, 1)]}`}
checked={this.state.round}
onChange={this.onRoundChange}
Expand Down

0 comments on commit 53ccece

Please sign in to comment.