Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding data-test-subj to super-date-picker #1782

Merged
merged 7 commits into from
Apr 3, 2019
Merged

Adding data-test-subj to super-date-picker #1782

merged 7 commits into from
Apr 3, 2019

Conversation

marius-dr
Copy link
Member

Summary

Adding missing data-test-subj fields to objects on the relative tab of datepicker

Checklist

N/A

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

Will be adding to the Kibana repo page_objects part as well.

@marius-dr
Adding data-test-subj
e0e4416 
Adding missing data-test-subj fields to missing objects on the relative tab
@marius-dr marius-dr requested a review from nreese March 31, 2019 21:43
nreese
nreese approved these changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the CHANGELOG

lgtm
code review

cchaos
cchaos suggested changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And reiterating about the need for a changelog entry.

src/components/date_picker/super_date_picker/date_popover/relative_tab.js Outdated Show resolved Hide resolved
nreese
nreese reviewed Apr 2, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
cchaos
cchaos suggested changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more Changelog change to make sure it's super clear what the item is referring to.

CHANGELOG.md Outdated Show resolved Hide resolved
@cchaos @marius-dr
Update CHANGELOG.md
4cc720f 
Co-Authored-By: marius-dr <marius-dr@users.noreply.github.com>
@marius-dr marius-dr requested a review from cchaos April 3, 2019 09:13
cchaos
cchaos approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marius-dr

@cchaos
Copy link
Contributor

cchaos commented Apr 3, 2019

jenkins, test this

cchaos
cchaos suggested changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marius-dr It looks like CI is failing because your indentations are a mix of tabs and spaces. Can you make sure that it's only spaces?

Screen Shot 2019-04-03 at 09 55 28 AM

@marius-dr marius-dr requested a review from cchaos April 3, 2019 14:19
cchaos
cchaos approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thx!

@marius-dr marius-dr merged commit 53ccece into elastic:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marius-dr @cchaos @nreese