-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EUI release(s) for 7.6 #2751
Comments
We also want to get as many of the a11y fixes into 7.6 as possible (we're going to be redoing the VPAT against 7.6 and a few other a11y things will peg off 7.6 as well). I went through the changelog and only could find #2455 as an a11y improvement even though I could have sworn there were others... (Maybe they all went in earlier?) |
I believe #2455 depends upon work in #2686, which is the reason that |
I think that if we get the latest master into a release and update the Kibana PR, then I can do all the hex value replacements directly in that PR and 🤞 we could get it into 7.6 |
Last rebase of the 18.0 PR against master breaks Kibana startup (?)(!). Working through that today, and even if it's ready Monday morning (which is my intent) it still needs review and approvals, so I don't imagine it will make the 7.6 cutoff via a [Kibana] backport. An EUI backport to our 17.x line, however, should be able to make a direct merge into Kibana 7.x |
I think it will be very tight for icons by Tuesday. I would assume we will have post FF release with those. Please don't work on the weekend to get 18.0 in. It either happens on monday/tuesday or it doesn't, but there's nothing in there super duper crazy that has me worried about cascading breaks. This wouldn't be the first time we've put an EUI release into Kibana post feature freeze, and as long as we're not talking many days past, let's not rush this. I'll grab us time if we need, but lets use work time, not weekend time. |
Kibana PR for EUI 18.0.0 is green; moved out of draft and ready for review (thanks to @cchaos for helping clear it up). |
@thompsongl is going to prep 18.1.0 based upon master and @chandlerprall's upgrade PR. He'll check out the ease of getting an upgrade in. If it looks hard, the current plan is to make an 18.0.x series to backport some smaller nav only fixes. Likely there will be a minor icon PR that will need a backport after these. |
Upgrading Kibana to |
Update
|
Both 18.0 and 18.2 will not be backported to 7.6? |
Edit: above, original message wasn't quite right 18.0 and 18.2 have all EUI commits intended for 7.6. EUI will not need a backport release, but both 18.0 and 18.2 are being backported to 7.x branch to make the 7.6 cut. |
Yes, @chandlerprall is correct, sorry for confusion. |
✅ master: elastic/kibana#54786 |
Provided
eui@18.0.0
does not merge tokibana@7.x
before 7.6 FF, we'll plan on the following:eui@18.1.0
releaseeui@17.4.0
backport release with:<Fragment />
asEuiNavDrawer
children #2710 (eui@18.0.0
)EuiNavDrawer
focus management, flyout auto-close #2749 (eui@18.1.0
)eui@17.4.0
(including7.x
branch)If the new solution icons are not available by Tuesday(ish):
eui@18.2.0
releaseeui@17.5.0
backport release with:eui@18.2.0
)eui@17.5.0
(including7.x
branch)Other commits to backport:
loading
on tables from re-mounting visible rows #2754 (eui@18.2.0
)eui@18.2.0
)The text was updated successfully, but these errors were encountered: