Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rk/add recently viewed icon #2755

Merged
merged 3 commits into from
Jan 13, 2020
Merged

Rk/add recently viewed icon #2755

merged 3 commits into from
Jan 13, 2020

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Jan 13, 2020 •
edited
Loading

Summary

Adds recentlyViewedApp glyph to EuiIcon for use in new Kibana grouped navigation.

Light and dark mode

Screenshot 2020-01-13 14 25 25

Screenshot 2020-01-13 14 25 37

Pixel-level detail

Screenshot 2020-01-13 13 46 45

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@ryankeairns ryankeairns requested a review from snide January 13, 2020 20:27
@thompsongl thompsongl mentioned this pull request Jan 13, 2020
Closed
6 tasks
snide
snide approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both light/dark and checked code. TY for the quick addition.

CHANGELOG.md Outdated Show resolved Hide resolved
@ryankeairns @snide
Update CHANGELOG.md
af0329d 
Co-Authored-By: dave.snider@gmail.com <dave.snider@gmail.com>
@ryankeairns ryankeairns merged commit df9e0b9 into elastic:master Jan 13, 2020
This was referenced Jan 14, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees
No one assigned
Labels
icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryankeairns @snide