Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v18.2.0 #54786

Merged
merged 15 commits into from
Jan 15, 2020
Merged

Upgrade EUI to v18.2.0 #54786

merged 15 commits into from
Jan 15, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jan 14, 2020 •
edited
Loading

Summary

eui@18.0.0 ⏩ eui@18.2.0

Color palette changes constituted the majority of changes. Individual color values as well as the access method(s) have changed and been updated by the Kibana design team in this changeset.

18.2.0

  • Added rencentlyViewedApp app icon to EuiIcon (#2755)

Bug fixes

  • Fixed EuiBasicTable & EuiInMemoryTable to not un- and re-mount rows when toggling loading prop (#2754)

18.1.0

  • Lightened EuiBadge hollow border color in dark mode (#2746)
  • Added minInputProps and maxInputProps to supply more props to the inputs of EuiDualRange (#2738)
  • Changed EuiBadge to use EUI palette colors (#2455)
  • Darkened a few euiPaletteColorBlind colors (#2455)
  • Fixed bug in EuiCard where button text was not properly aligned (#2741)
  • Converted EuiRange to TypeScript (#2732)
  • Converted EuiDualRange to TypeScript (#2732)
  • Converted EuiRangeInput to TypeScript (#2732)
  • Added bellSlash glyph to EuiIcon (#2714)
  • Added legend prop to EuiCheckboxGroup and EuiRadioGroup to add EuiFieldset wrappers for title the groups (#2739)
  • Changed EuiNavDrawerFlyout to close after child nav items are clicked (#2749)
  • Changed EuiNavDrawerFlyout to trap focus while navigating via keyboard (#2749)
  • Created a euiPaletteColorBlindBehindText variant of the color blind palette (#2750)
  • Improved focus state of EuiSwitch, EuiCheckbox, EuiRadio and EuiRange (#2745)

Bug fixes

  • Changed EuiRadio and EuiCheckbox labels to be inline-block (#2739)
  • Fixed EuiCheckboxGroup's options type to fully extend the EuiCheckbox type (#2739)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.6.0 labels Jan 14, 2020
@thompsongl thompsongl marked this pull request as ready for review January 14, 2020 22:37
@thompsongl thompsongl requested a review from a team as a code owner January 14, 2020 22:37
@thompsongl thompsongl requested a review from a team January 14, 2020 22:37
@thompsongl thompsongl requested review from a team as code owners January 14, 2020 22:37
myasonik
myasonik approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

lizozom
lizozom approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/kibana-app-arch change lgtm

chandlerprall
chandlerprall approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Reviewed changes to package.json files, snapshots, and yarn.lock

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

snide
snide approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked over the hex changes to make sure nothing was amiss.

@thompsongl thompsongl merged commit bd9d67c into elastic:master Jan 15, 2020
@thompsongl thompsongl mentioned this pull request Jan 15, 2020
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Jan 15, 2020
@thompsongl @cchaos @chandlerprall
Upgrade EUI to v18.2.0 (elastic#54786)
3ebd921 
* 18.2.0

* ts update

* Updated `euiColorVis0`

* Update `euiColorVis1`

* Updating `euiColorVis2`

* Updated `euiColorVis3`

* Updated the rest

* Updated hard-coded viz palette hexes to latest

* src snapshot updates

* x-pack test updates

* mock jest fn

* Updated two vegalite visualization screenshots

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
thompsongl added a commit that referenced this pull request Jan 15, 2020
@thompsongl @cchaos @chandlerprall
[7.x] Upgrade EUI to v18.2.0 (#54786) (#54869)
e0d6407 
* Upgrade EUI to v18.2.0 (#54786)

* 18.2.0

* ts update

* Updated `euiColorVis0`

* Update `euiColorVis1`

* Updating `euiColorVis2`

* Updated `euiColorVis3`

* Updated the rest

* Updated hard-coded viz palette hexes to latest

* src snapshot updates

* x-pack test updates

* mock jest fn

* Updated two vegalite visualization screenshots

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Chandler Prall <chandler.prall@gmail.com>

* snapshot

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 15, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master'
bfdb1ea 
* upstream/master: (72 commits)
  [ML] Calculate model memory limit API integration tests (elastic#54557)
  Skip flakey index template component integration tests. (elastic#54878)
  Add label and icon to nested fields in the doc table (elastic#54199)
  Reverse dependency of home plugin and apm/ml/cloud (elastic#52883)
  [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules
  update invalid snapshot
  add readme note about alerting / manage_api_key cluster privilege (elastic#54639)
  [SIEM] New Overview Page (elastic#54783)
  [Uptime] Feature/refactor context initialization (elastic#54494)
  Upgrade EUI to v18.2.0 (elastic#54786)
  [SIEM] [Detection engine] from signals to timeline (elastic#54769)
  [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562)
  [SIEM][Detection Engine] Removes deprecated filter from mapping
  [Maps] Add categorical styling (elastic#54408)
  Add mapbox-gl-rtl-text library (elastic#54842)
  [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828)
  Lexicographically sort location tags (elastic#54832)
  [Maps] expand extent filter to tile boundaries (elastic#54276)
  [Maps] Use v7.6 Elastic Maps Service API (elastic#54399)
  [DOCS] Adds monitoring setting (elastic#54819)
  ...
@thompsongl thompsongl mentioned this pull request Jan 15, 2020
Closed
6 tasks
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@thompsongl @cchaos
@chandlerprall @jkelastic
Upgrade EUI to v18.2.0 (elastic#54786)
9dfb199 
* 18.2.0

* ts update

* Updated `euiColorVis0`

* Update `euiColorVis1`

* Updating `euiColorVis2`

* Updated `euiColorVis3`

* Updated the rest

* Updated hard-coded viz palette hexes to latest

* src snapshot updates

* x-pack test updates

* mock jest fn

* Updated two vegalite visualization screenshots

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myasonik myasonik myasonik approved these changes

@lizozom lizozom lizozom approved these changes

@snide snide snide approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thompsongl @kibanamachine @chandlerprall @snide @lizozom @myasonik