Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanding rows not working in EuiInMemoryTable #690

Closed
peteharverson opened this issue Apr 19, 2018 · 0 comments
Closed

Expanding rows not working in EuiInMemoryTable #690

peteharverson opened this issue Apr 19, 2018 · 0 comments
Assignees
@chandlerprall
Labels
bug

Comments

@peteharverson
Copy link

Expanding row functionality does not work in EuiInMemoryTable.

Looking at the code of in_memory_table.js, it looks like the itemIdToExpandedRowMap prop of EuiInMemoryTable is not being passed to EuiBasicTable in the render function.

Found in version 0.0.38
@snide snide mentioned this issue Apr 30, 2018
Closed
44 tasks
chandlerprall added a commit to chandlerprall/eui that referenced this issue May 2, 2018
@chandlerprall
Pass itemIdToExpandedRowMap prop from EuiInMemoryTable to EuiBasicTab…
1ef05a7 
…le, fixes elastic#690
@chandlerprall chandlerprall mentioned this issue May 2, 2018
Merged
@chandlerprall chandlerprall self-assigned this May 2, 2018
chandlerprall added a commit that referenced this issue May 2, 2018
@chandlerprall
Pass itemIdToExpandedRowMap prop from EuiInMemoryTable to EuiBasicTab…
fdd9714 
…le (#759)

* Pass itemIdToExpandedRowMap prop from EuiInMemoryTable to EuiBasicTable, fixes #690

* Updated unit test to cover case, updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chandlerprall chandlerprall

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chandlerprall @snide @peteharverson