Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass itemIdToExpandedRowMap prop from EuiInMemoryTable to EuiBasicTable #759

Merged
merged 2 commits into from
May 2, 2018
Merged

Pass itemIdToExpandedRowMap prop from EuiInMemoryTable to EuiBasicTable #759

merged 2 commits into from
May 2, 2018

Conversation

chandlerprall
Copy link
Contributor

Fixes #690 by passing the itemIdToExpandedRowMap prop down from EuiInMemoryTable to EuiBasicTable.

@chandlerprall chandlerprall requested review from snide and cjcenizal May 2, 2018 16:35
cjcenizal
cjcenizal approved these changes May 2, 2018
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM

@chandlerprall chandlerprall merged commit fdd9714 into elastic:master May 2, 2018
@chandlerprall chandlerprall deleted the bug/690-euiinmemorytable-expanding-rows branch May 2, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@snide snide snide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chandlerprall @snide @cjcenizal