Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding data-test-subj to super-date-picker #1782

Merged
merged 7 commits into from
Apr 3, 2019
Merged

Adding data-test-subj to super-date-picker #1782

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e0e4416
Adding data-test-subj
marius-dr Mar 31, 2019
3eeffc9
Update CHANGELOG.md
marius-dr Apr 2, 2019
dd03024
fixed spacing
marius-dr Apr 2, 2019
9e38e76
Merge branch 'master' into master
marius-dr Apr 2, 2019
78fba90
Update CHANGELOG.md
marius-dr Apr 2, 2019
4cc720f
Update CHANGELOG.md
cchaos Apr 3, 2019
9d0c282
Fix tabs to spaces
marius-dr Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Converted `EuiFormErrorText` to TS ([#1772](https://github.com/elastic/eui/pull/1772))

- Added data-test-subj to TimePicker ([#1782](https://github.com/elastic/eui/pull/1782))
marius-dr marked this conversation as resolved.
Show resolved Hide resolved
**Bug fixes**

- Update ButtonIconColor type to provide all available options ([#1783](https://github.com/elastic/eui/pull/1783))
Expand Down
3 changes: 3 additions & 0 deletions src/components/date_picker/super_date_picker/date_popover/relative_tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ export class EuiRelativeTab extends Component {
>
<EuiFieldNumber
aria-label="Count of"
data-test-subj={`superDatePickerRelativeDateInputNumber`}
value={this.state.count}
onChange={this.onCountChange}
isInvalid={isInvalid}
Expand All @@ -78,6 +79,7 @@ export class EuiRelativeTab extends Component {
<EuiFlexItem>
<EuiFormRow>
<EuiSelect
data-test-subj={`superDatePickerRelativeDateInputUnitSelector`}
value={this.state.unit}
options={relativeOptions}
onChange={this.onUnitChange}
Expand All @@ -90,6 +92,7 @@ export class EuiRelativeTab extends Component {
</EuiFormRow>
<EuiFormRow>
<EuiSwitch
data-test-subj={`superDatePickerRelativeDateRoundSwitch`}
label={`Round to the ${timeUnits[this.state.unit.substring(0, 1)]}`}
checked={this.state.round}
onChange={this.onRoundChange}
Expand Down