Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing TS definition for EuiFieldText #1977

Merged
merged 3 commits into from
May 30, 2019
Merged

Add missing TS definition for EuiFieldText #1977

merged 3 commits into from
May 30, 2019

Conversation

maryia-lapata
Copy link
Contributor

@maryia-lapata maryia-lapata commented May 30, 2019 •
edited
Loading

Summary

Add missing TypeScript definition for EuiFieldText's compressed prop.

This changes are needed for the PR elastic/kibana#37476

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

This was referenced May 30, 2019
Merged
Merged
chandlerprall
chandlerprall approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM

cchaos
cchaos approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a changelog comment

CHANGELOG.md Outdated Show resolved Hide resolved
@maryia-lapata maryia-lapata merged commit 7ef3f51 into elastic:master May 30, 2019
@maryia-lapata maryia-lapata deleted the fieldtext-types branch May 30, 2019 14:43
@thompsongl thompsongl mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

@PhilippBaranovskiy PhilippBaranovskiy Awaiting requested review from PhilippBaranovskiy

@thompsongl thompsongl Awaiting requested review from thompsongl

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maryia-lapata @chandlerprall @cchaos