Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security, logging, maps, uptime and code solution icons #2111

Merged
merged 5 commits into from
Jul 12, 2019
Merged

Add security, logging, maps, uptime and code solution icons #2111

merged 5 commits into from
Jul 12, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Jul 11, 2019 •
edited
Loading

Summary

Adds missing solution logos for security, logging and code. Removes Xpack logo, which is NOT used in Kibana currently and is safe to remove.

image

image

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide requested a review from cchaos July 11, 2019 21:17
@snide
Copy link
Contributor Author

snide commented Jul 11, 2019

cc @MichaelMarcialis as this related to elastic/kibana#40899

Will create a release and Kibana PR after merge

@snide snide requested a review from gjones July 11, 2019 21:25
@gjones
Copy link
Contributor

gjones commented Jul 11, 2019

Sorry, can we get Uptime too? and probably maps although personally I don't need that one.

logo-solutions-uptime-monitoring-bb

@snide
Copy link
Contributor Author

snide commented Jul 12, 2019

Feedback addressed, uptime and maps added as well. Screens updated in description.

@snide snide requested a review from cchaos July 12, 2019 03:07
@snide snide changed the title Add security, logging and code solution icons Add security, logging, maps, uptime and code solution icons Jul 12, 2019
@snide
Copy link
Contributor Author

snide commented Jul 12, 2019

Maps fixed. Also added these to sketch, since they were missing there as well.

@snide snide requested a review from cchaos July 12, 2019 15:18
cchaos
cchaos approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thx

@snide snide merged commit 9813867 into elastic:master Jul 12, 2019
@snide snide deleted the logos/siem branch July 12, 2019 15:47
@snide snide mentioned this pull request Jul 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@gjones gjones gjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snide @gjones @cchaos