Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Updates add data references of "Security analytics" to "SIEM" #40899

Merged
merged 5 commits into from
Jul 12, 2019
Merged

[SIEM] Updates add data references of "Security analytics" to "SIEM" #40899

merged 5 commits into from
Jul 12, 2019

Conversation

MichaelMarcialis
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis commented Jul 11, 2019 •
edited
Loading

Summary

This PR updates prior references of "Security analytics" to "SIEM" on the Kibana home and add data pages. It also updates prior usage of the securityApp icon to the securityAnalyticsApp icon.

image

image

Related Issue: https://github.com/elastic/ingest-dev/issues/532

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@MichaelMarcialis MichaelMarcialis added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.3.0 v7.4.0 labels Jul 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/secops

@snide
Copy link
Contributor

snide commented Jul 11, 2019 •
edited
Loading

hey @MichaelMarcialis. I think with this change we can likely change that top set to be the "solutions" style logos, rather than the app icons. There was a ticket for it, but we didn't have all the logos finalized at the time. #32399

I think we might have to add the SIEM logo into EUI though as well, since it looks like only the app icon came over. I'm sure @JessSmithSup has it somewhere.

FrankHassanabad
FrankHassanabad approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Checked out the PR in my environment
  • Tested the links and ensured that the Add Data and the new links such as tutorial_directory/siem all worked out as expected.
  • Checked the word SIEM shows up as well

Everything works and appreciate the extra variable change for APM.

👍 , Giving this the good ole' L - G - T - M

@elasticmachine
Copy link
Contributor

💔 Build Failed

@MichaelMarcialis
Copy link
Contributor Author

hey @MichaelMarcialis. I think with this change we can likely change that top set to be the "solutions" style logos, rather than the app icons. There was a ticket for it, but we didn't have all the logos finalized at the time. #32399

I think we might have to add the SIEM logo into EUI though as well, since it looks like only the app icon came over. I'm sure @JessSmithSup has it somewhere.

Hey, @snide. Sure, I don't mind making the logo addition to EUI if @JessSmithSup can pass me the SVG.

Just to double check with @MikePaquette, do you have any issue with us using the SIEM logo rather than the icon?

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@MikePaquette
Copy link

@MichaelMarcialis No problems using the SIEM solution logo. I'm assuming that the other icons are also going to be changed to logos for consistency?

@snide snide mentioned this pull request Jul 11, 2019
Merged
10 tasks
@JessSmithSup
Copy link

@MichaelMarcialis
SIEM logo is here

LMK if that works

@MichaelMarcialis
Copy link
Contributor Author

Per conversation with @snide, going to switch to logos in a separate PR, as the next EUI release is going through some testing.

@MichaelMarcialis MichaelMarcialis merged commit 29a8bc8 into elastic:master Jul 12, 2019
@MichaelMarcialis MichaelMarcialis deleted the bug/ingest-dev-532/add-data-siem branch July 12, 2019 19:11
This was referenced Jul 12, 2019
Merged
Merged
MichaelMarcialis added a commit to MichaelMarcialis/kibana that referenced this pull request Jul 12, 2019
@MichaelMarcialis
[SIEM] Update Add Data References of "Security analytics" to "SIEM" (e…
ebdffda 
…lastic#40899)

* change add data security references to siem

* update links to siem add data page

* update snapshot

* fix translations
MichaelMarcialis added a commit to MichaelMarcialis/kibana that referenced this pull request Jul 12, 2019
@MichaelMarcialis
[SIEM] Update Add Data References of "Security analytics" to "SIEM" (e…
812d3e9 
…lastic#40899)

* change add data security references to siem

* update links to siem add data page

* update snapshot

* fix translations
MichaelMarcialis added a commit that referenced this pull request Jul 12, 2019
@MichaelMarcialis
[SIEM] Update Add Data References of "Security analytics" to "SIEM" (#…
d453b78 
…40899) (#41043)

* change add data security references to siem

* update links to siem add data page

* update snapshot

* fix translations
MichaelMarcialis added a commit that referenced this pull request Jul 12, 2019
@MichaelMarcialis
[SIEM] Update Add Data References of "Security analytics" to "SIEM" (#…
48a42b5 
…40899) (#41044)

* change add data security references to siem

* update links to siem add data page

* update snapshot

* fix translations
@FrankHassanabad FrankHassanabad changed the title [SIEM] Update Add Data References of "Security analytics" to "SIEM" [SIEM] Updates add data references of "Security analytics" to "SIEM" Jul 30, 2019
@FrankHassanabad FrankHassanabad added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Jul 30, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@MikePaquette MikePaquette Awaiting requested review from MikePaquette

Assignees
No one assigned
Labels
release_note:fix Team:SIEM v7.3.0 v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MichaelMarcialis @elasticmachine @snide @MikePaquette @JessSmithSup @FrankHassanabad